Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix [[Delete]] operation for fast arrays. #3115

Merged
merged 1 commit into from
Sep 16, 2019

Conversation

rerobika
Copy link
Member

When popping the last element from a fast array the underlying buffer must be released.
This patch fixes #3106.

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]

When popping the last element from a fast array the underlying buffer must be released.
This patch fixes jerryscript-project#3106.

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]
@rerobika rerobika added the bug Undesired behaviour label Sep 13, 2019
Copy link
Member

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@DanielBallaSZTE DanielBallaSZTE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (informal).

Copy link
Member

@dbatyai dbatyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbatyai dbatyai merged commit 436fcbb into jerryscript-project:master Sep 16, 2019
@rerobika rerobika deleted the fix_issue_3106 branch June 16, 2020 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Undesired behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assertion 'JERRY_CONTEXT (jmem_heap_allocated_size) == 0' in jmem-heap.c
4 participants