Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not working #16

Closed
Professor-Sathish opened this issue Sep 20, 2021 · 9 comments
Closed

not working #16

Professor-Sathish opened this issue Sep 20, 2021 · 9 comments

Comments

@Professor-Sathish
Copy link

No description provided.

@jerry1100
Copy link
Owner

Thanks for the report, will take a look later today.

@jerry1100
Copy link
Owner

I was able to repro it not working, but not consistently.

Can you try toggling the extension off & on again?
image

@Professor-Sathish
Copy link
Author

Professor-Sathish commented Sep 26, 2021 via email

@jerry1100
Copy link
Owner

I'm not sure why it's being inconsistent, but it will take some time to investigate and fix it.

In the meantime, for those who are also hitting this issue, please try toggling the extension off/on again and trying again. Leave a comment here as well.

@saltzimania
Copy link

Toggling is inconsistent and sometimes works, sometimes doesn't but it is indeed a workaround - thanks!

@martin-braun
Copy link

martin-braun commented Oct 13, 2021

Can confirm, it was opening the normal dropdown instead of opening the print dialog when I click it. After disabling and re-enabling the extension it works again, but it fails to show proper margins:

Screen Shot 2021-10-13 at 17 51 39

When I attempted to do it again margins were correct, so there is some sort of inconsistency. I have to try several times until it works.

@jerry1100
Copy link
Owner

Interesting. Thanks for the additional info @martin-braun.

Sorry for the delay in fixing this, work and life has been taking up most of my time.

@martin-braun
Copy link

martin-braun commented Oct 14, 2021

Interesting. Thanks for the additional info @martin-braun.

Sorry for the delay in fixing this, work and life has been taking up most of my time.

Take your time all good, your extension is still usable, but the issue repeats for each page I want to print with it.

First I have to re enable the extension, then I have to reload the page and then I have to click the extension and open the print dialog twice to get the right result without wrong margins. It seems there is something on the DOM happening that will be fixed when executed a second time.

I have no clue regarding the initial load issue though. All I can say is I'm on Brave and macOS. If you need any diagnostics, please instruct me and I can provide it.

Please consider taking care of real life stuff first. This has more priority definitely. 🙂

@jerry1100
Copy link
Owner

Thanks for being patient. Sorry I didn't get to this earlier.

Happy to report that v0.8 is published which should fix this issue. It's available now on the chrome store and should be on the edge store in a few days.

demo

If for some reason it's still not working, feel free to reopen this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants