Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update CI to the latest Elixir 1.11 and Erlang 23. Add Elixir 1.12 and Erlang 24 #436

Merged

Conversation

baseballlover723
Copy link
Contributor

@baseballlover723 baseballlover723 commented Aug 3, 2021

Also upgrades the local Elixir version to 1.12.2 and the Erlang version to 24.0.5. This also includes a mix format since Elixir 1.12 made a backwards incompatible formatting change as well as only running the format check in CI on Elixir 1.12+.

This also changes CI to not fail as soon a single job fails, this is needed for now, since CI fails on Erlang 24. This is probably for the better since you can see if CI fails for just a single Elixir / Erlang combination or for all of them.

@baseballlover723 baseballlover723 force-pushed the pr/add_new_elixir_erlang_ci branch 2 times, most recently from b1b5603 to f5adc67 Compare August 3, 2021 23:50
@baseballlover723 baseballlover723 changed the title update to the latest Elixir 1.11 and Erlang 23. Add Elixir 1.12 and Erlang 24 update CI to the latest Elixir 1.11 and Erlang 23. Add Elixir 1.12 and Erlang 24 Aug 3, 2021
@baseballlover723 baseballlover723 force-pushed the pr/add_new_elixir_erlang_ci branch 3 times, most recently from 9a3a75a to 242c0e8 Compare August 4, 2021 00:34
@jeremyjh
Copy link
Owner

jeremyjh commented Aug 4, 2021

Hi, thanks for working on this! I think to resolve the errors on OTP 24 we could just remove this entire check from the tests:

run: mix dialyzer --list-unused-filters
; it would be hard to keep broad compatibility and still check this.

Also, I would be fine with dropping the 1.9.4 targets entirely since that is 4 releases ago, my original thought was to support the 3 most recent releases anyway.

@baseballlover723
Copy link
Contributor Author

This has been updated

@baseballlover723 baseballlover723 force-pushed the pr/add_new_elixir_erlang_ci branch 5 times, most recently from e855b0f to ff8a62f Compare September 2, 2021 02:59
@baseballlover723
Copy link
Contributor Author

I have no idea why the tests fail now, but most of them did work when I originally pushed it up, https://github.com/jeremyjh/dialyxir/runs/3248958978

@jeremyjh
Copy link
Owner

jeremyjh commented Sep 3, 2021

The problem is we're no longer running any dialyzer check before the output_test, so output_test has to build the PLTs etc. Re-ordering the output tests like this will fix it.

@jeremyjh jeremyjh merged commit e8c46d6 into jeremyjh:master Sep 9, 2021
@jeremyjh
Copy link
Owner

jeremyjh commented Sep 9, 2021

Thanks!

@baseballlover723 baseballlover723 deleted the pr/add_new_elixir_erlang_ci branch September 9, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants