Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-71183] Fix Build actions anonymization enable UI check #462

Merged
merged 1 commit into from
May 3, 2023

Conversation

Dohbedoh
Copy link
Contributor

@Dohbedoh Dohbedoh commented May 3, 2023

JENKINS-71183: same as #326 but for the Run action.

Testing done

  • Start Jenkins
  • Create a Pipeline Job and build it once
  • Go to the build page
  • Open the "Build Support" link
  • Validate that the anonymization warnings says that anonymization is disabled
  • Go to Manage Jenkins > Configure Global Security > Support Anonymization and enable it
  • Go back to the build page
  • Open the "Build Support" link
  • Validate that the anonymization message says that anonymization is enabled

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@Dohbedoh Dohbedoh requested a review from a team as a code owner May 3, 2023 02:01
@Dohbedoh Dohbedoh added the bug label May 3, 2023
@jglick
Copy link
Member

jglick commented May 3, 2023

Did you mean to compare this to #326?

@@ -30,6 +33,12 @@ protected String getBundleNameQualifier() {
return "build";
}

@Restricted(NoExternalUse.class) // stapler
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(or DoNotUse works)

@Dohbedoh Dohbedoh merged commit f26a78c into jenkinsci:master May 3, 2023
@Dohbedoh Dohbedoh deleted the JENKINS-71183 branch May 3, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants