Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if defined enable keystore in init container, update statefulset as w… #662

Merged
merged 1 commit into from
Jul 1, 2022
Merged

if defined enable keystore in init container, update statefulset as w… #662

merged 1 commit into from
Jul 1, 2022

Conversation

lknite
Copy link
Contributor

@lknite lknite commented Jul 1, 2022

…ell as Chart & Changelog

Signed-off-by: leland knight [email protected]

What this PR does / why we need it

The helm chart allows a keystore to be specified. This works great. However, the init pod does not currently benefit from the existing keystore, if there is one. This pull request adds the keystore to the init pod by copy/pasting the section already defined to mount the keystore in the jenkins pod to also mount within the init pod.

Which issue this PR fixes

This fix is a stand alone feature enhancement, making sure that if a keystore is defined, it is also made available in the init pod.

Though not an exact fix, it is possible to use this addition to resolve the following without having to create and manage a custom jenkins image file.

Special notes for your reviewer

Though a more advanced fix would be to define and integrate both a keystore and a truststore into the helm chart for both the jenkins pod and the init pod, this pull request would be good in the meantime as it allows the mounting of the currently implemented keystore to also exist within the init pod.

Checklist

  • DCO signed
  • Chart Version bumped
  • CHANGELOG.md was updated

…ell as Chart & Changelog

Signed-off-by: leland knight <[email protected]>
@lknite lknite requested a review from a team as a code owner July 1, 2022 19:53
@lknite
Copy link
Contributor Author

lknite commented Jul 1, 2022

Canceled my previous pull request. Was following some steps to add a sign-off after the fact and it got a little messy.

Submitted this new clean pull request with all checklist steps performed as expected and 3 files changes in a single commit.

Ready for approval.

@timja timja merged commit 4bcaf85 into jenkinsci:main Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants