if defined enable keystore in init container, update statefulset as w… #662
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ell as Chart & Changelog
Signed-off-by: leland knight [email protected]
What this PR does / why we need it
The helm chart allows a keystore to be specified. This works great. However, the init pod does not currently benefit from the existing keystore, if there is one. This pull request adds the keystore to the init pod by copy/pasting the section already defined to mount the keystore in the jenkins pod to also mount within the init pod.
Which issue this PR fixes
This fix is a stand alone feature enhancement, making sure that if a keystore is defined, it is also made available in the init pod.
Though not an exact fix, it is possible to use this addition to resolve the following without having to create and manage a custom jenkins image file.
Special notes for your reviewer
Though a more advanced fix would be to define and integrate both a keystore and a truststore into the helm chart for both the jenkins pod and the init pod, this pull request would be good in the meantime as it allows the mounting of the currently implemented keystore to also exist within the init pod.
Checklist