Fix issue 592 by adding a regexMatch condition #623
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stijn Brouwers <[email protected]>
Signed-off-by: Stijn Brouwers <[email protected]>
timja
reviewed
May 13, 2022
There was a problem hiding this comment.
what about just removing remotingSecurity: enabled: true completely?
People on an older version can re-add it themselves if they want to keep it but we should remove it from the defaults?
This regex is quite complicated and will still fail if people don't include the version
|
For me that sounds good. |
Ah I hadn't seen that, yes that would work and it should be defaulted to not including this |
|
OK, that's better. Shall I just close this PR without merging then? |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stijn Brouwers [email protected]
What this PR does / why we need it
Fixes issue 592 by first applying a regex match to the official semver regex (https://semver.org/#is-there-a-suggested-regular-expression-regex-to-check-a-semver-string) with a small modification: The patch part of the regex had to be made optional for this to work.
Which issue this PR fixes
Special notes for your reviewer
Checklist