Fix config reload request url when httpsKeystore in use #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 2, 2021 13:25
…bled for config reload request url Signed-off-by: Paul Hoisington <[email protected]>
Signed-off-by: Paul Hoisington <[email protected]>
Signed-off-by: Paul Hoisington <[email protected]>
justusbunsi
reviewed
Dec 2, 2021
|
Whoops - I saw your name in a recent PR merge, @justusbunsi, so I added you. Apologies - I won't ping you again! |
|
No worries. I am happy to contribute if I can. So pings are welcome. It just was unexpected. 😀 |
Signed-off-by: Paul Hoisington <[email protected]>
timja
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Previously, the config reload sidecar's request URL pointed to the
targetPort, which, when the httpsKeystore is in use, is set to8443in our configuration. The sidecar ends up POSTing HTTP->HTTPS, which results in aBadStatusLineerror when the sidecar attempts a configuration reload. This PR fixes the REQ_URL environment variable's template to correctly use the definedhttpsKeyStore.httpPortwhen the httpsKeyStore is enabled, like other uses oftargetPortdo.Special notes for your reviewer
@torstenwalter @justusbunsi @nikonorovi
Checklist