Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring token expiry check #150

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ash1425
Copy link

@ash1425 ash1425 commented Dec 25, 2020

We had introduced additional abstract class to add token expiry awareness in last release. This made it 3 levels of abstract classes.

After looking into it closely, I think probably it's a good idea to make token expiry aware a default behaviour - as this is useful in all the cases except plain token based secret.

About duplication of token expiry checking logic in JCasC and Credentials - I think this needs a bigger refactoring. We should extract Vault Authentication mechanism in a common place and it should be used by both credentials and JCasC secrets code.

…t's probably a better idea to always check for token expiry as a default behaviour
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant