Fix incrementals #353
Merged
Fix incrementals #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Incrementals deployed: |
MarkEWaite
added a commit
to MarkEWaite/github-plugin
that referenced
this pull request
Oct 10, 2023
Java 21 was released Sep 19, 2023. We want to announce full support for Java 21 in early October and would like the most used plugins to be compiled and tested with Java 21. The acceptance test harness and plugin bill of materials tests are already passing with Java 21. This is a further step to improve plugin readiness for use with Java 21 and for development with Java 21. The change intentionally tests only two Java configurations, Java 17 and Java 21 because we believe that the risk of a regression that only affects Java 11 is low. We generate Java 11 byte code with the Java 17 and the Java 21 builds, so we're already testing Java 11 byte code. Also updates parent pom to most current release and removes unneeded hamcrest dependency declaration. Supersedes pull request: * jenkinsci#367 * jenkinsci#366 * jenkinsci#361 * jenkinsci#360 * jenkinsci#359 * jenkinsci#353 * jenkinsci#352
MarkEWaite
added a commit
to MarkEWaite/github-plugin
that referenced
this pull request
Oct 10, 2023
Java 21 was released Sep 19, 2023. We want to announce full support for Java 21 in early October and would like the most used plugins to be compiled and tested with Java 21. The acceptance test harness and plugin bill of materials tests are already passing with Java 21. This is a further step to improve plugin readiness for use with Java 21 and for development with Java 21. The change intentionally tests only two Java configurations, Java 17 and Java 21 because we believe that the risk of a regression that only affects Java 11 is low. We generate Java 11 byte code with the Java 17 and the Java 21 builds, so we're already testing Java 11 byte code. Also updates parent pom to most current release and removes unneeded hamcrest dependency declaration. Supersedes pull request: * jenkinsci#367 * jenkinsci#366 * jenkinsci#361 * jenkinsci#360 * jenkinsci#359 * jenkinsci#353 * jenkinsci#352
oleg-nenashev
pushed a commit
that referenced
this pull request
Nov 12, 2023
* Test with Java 21 Java 21 was released Sep 19, 2023. We want to announce full support for Java 21 in early October and would like the most used plugins to be compiled and tested with Java 21. The acceptance test harness and plugin bill of materials tests are already passing with Java 21. This is a further step to improve plugin readiness for use with Java 21 and for development with Java 21. The change intentionally tests only two Java configurations, Java 17 and Java 21 because we believe that the risk of a regression that only affects Java 11 is low. We generate Java 11 byte code with the Java 17 and the Java 21 builds, so we're already testing Java 11 byte code. Also updates parent pom to most current release and removes unneeded hamcrest dependency declaration. Supersedes pull request: * #367 * #366 * #361 * #360 * #359 * #353 * #352 * Test Java 11 directly Address the concern that Oleg expressed in #368 (review) We've detected no regressions with the transition to testing Java 11 byte code as generated by Java 17 and Java 21 compilers in the 200+ plugins that have made the transition. We test with Java 11 on older lines (Jenkins 2.401.x and Jenkins 2.414.x) in the plugin bill of materials while testing with Java 21 on the most recent weekly release. We've detected no issues with any of the plugins that are included in the plugin BOM. We want to reduce Jenkins infrastructure costs by not testing configurations that are unlikely to detect issues. Testing with Java 11 is unlikely to detect issues and adds infrastructure cost. I've added Java 11 on Linux as a test configuration. I do not intend to make that same addition on the other 100+ repositories where we're testing with Java 21 and Java 17. When a plugin maintainer asks to continue testing Java 11, I'm willing to adapt that pull request. * Revert "Test Java 11 directly" This reverts commit 6d8ef2f.
|
I guess maven-release-plugin will revert it during every release |
Recent versions of Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incrementals deployment of https://ci.jenkins.io/job/Plugins/job/github-plugin/job/master/124/console failed with: