Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-60738] Fix global configuration submission from UI #347

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[JENKINS-60738] Fix global configuration submission from UI #347

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cfaa0c4
[JENKINS-60738] Fix global configuration submission from UI
Dohbedoh May 2, 2023
3a5d46f
[JENKINS-60738] Fix json binding for arrays
Dohbedoh May 3, 2023
a6ec398
Merge branch 'master' into JENKINS-60738
Dohbedoh Jun 20, 2023
b14789f
Merge branch 'master' into JENKINS-60738
Dohbedoh Sep 27, 2023
929dbe3
Merge branch 'master' into JENKINS-60738
Dohbedoh Nov 2, 2023
e8952dd
Merge branch 'master' into JENKINS-60738
Dohbedoh Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[JENKINS-60738] Fix json binding for arrays
  • Loading branch information
@Dohbedoh
Dohbedoh committed May 3, 2023
commit 3a5d46fa1f0725cf68b0e9cbde26249cd2c9d146
5 changes: 2 additions & 3 deletions src/main/java/org/jenkinsci/plugins/github/config/GitHubPluginConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,13 +195,12 @@ public boolean configure(StaplerRequest req, JSONObject json) throws FormExcepti
BulkChange bc = new BulkChange(this);
try {
if (json.has("configs")) {
setConfigs(req.bindJSONToList(GitHubServerConfig.class, json.getJSONObject("configs")));
setConfigs(req.bindJSONToList(GitHubServerConfig.class, json.get("configs")));
} else {
setConfigs(Collections.emptyList());
}
if (json.has("hookSecretConfigs")) {
setHookSecretConfigs(req.bindJSONToList(HookSecretConfig.class,
json.getJSONObject("hookSecretConfigs")));
setHookSecretConfigs(req.bindJSONToList(HookSecretConfig.class, json.get("hookSecretConfigs")));
} else {
setHookSecretConfigs(Collections.emptyList());
}
Expand Down
Loading