End Pr210 #221
End Pr210 #221
Conversation
… simply deprecate the overrideHookUrl, and adding additional tests
|
@timja ping |
src/test/java/org/jenkinsci/plugins/github/test/GitHubServerConfigMatcher.java
Outdated
Show resolved
Hide resolved
src/test/java/org/jenkinsci/plugins/github/test/GitHubServerConfigMatcher.java
Outdated
Show resolved
Hide resolved
|
|
||
| @Test | ||
| @ConfiguredWithCode("configuration-as-code.yml") | ||
| public void exportConfiguration() throws Exception { |
There was a problem hiding this comment.
you could probably write a simpler test with a fixture, there's nothing dynamic here so should be straightforward:
https://github.com/jenkinsci/slack-plugin/blob/master/src/test/java/jenkins/plugins/slack/jcasc/ConfigurationAsCodeTest.java#L34
There was a problem hiding this comment.
What is the difference with the source yaml?
There was a problem hiding this comment.
the source yaml is the same, the expected one doesn't have the attribute that you do a .get on, in the case of slack it's missing slackNotifier but has all the fields under it
There was a problem hiding this comment.
i not sure also btw, final yaml is missing default return settings, is it ok?
There was a problem hiding this comment.
@timja i can merge&release finally this caasc support and i can accept PR for test update if you want to change it
There was a problem hiding this comment.
probably not worth it, it works and is unlikely to ever need to change.
Co-Authored-By: Tim Jacomb <[email protected]>
|
Thanks @KostyaSha ! |
|
Thanks for CasC :) Waiting for read only global options. |
|
Thanks @KostyaSha for finishing this up 😊 |
|
This seems like it's a problem. Is there any fix looking for overriding the hook url? https://issues.jenkins-ci.org/browse/JENKINS-60738 @KostyaSha |
closes #210
This change is