-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Deprecate magic method. #149
base: master
Are you sure you want to change the base?
Conversation
admin:repo_hook mention in help
handle exceptions of extensions
will be useful in repository name
caused by self-test validation for custom hook url
fix "Unknown content type null" in logs and since for 1.12.0 api
See JENKINS-29794 for details.
[JENKINS-29787] Fix NPE for race condition(?).
instead of own plain token usage
- with credentials usage - with migrator from old gh-push-trigger descriptor config options to new gh-plugin - with bean class to store deprecated creds (used only for migration)
+ reformat some code + add getters for fields
cleanup all gh-push-trigger descriptor related lines
- for migration process - for changes in hooks - for configuration logic
- change dontManageHooks=false to manageHooks=true
…nced also fix some phrases in javadocs and help
also don't bother signature validation if no header from github with signature
[JENKINS-33974] Payload verification using shared secrets
[JENKINS-37481] Ignore sign header if sign not defined in Jenkins
Allow for commit status backref configuration
* [FIXED JENKINS-38347] Use Initializer levels. - migrator: Don't throw NPE because Descriptor wasn't ready. - aliases: user annotation initializer. * Ensure execution order. Signed-off-by: Kanstantsin Shautsou <[email protected]> * Move to javadoc
Signed-off-by: Kanstantsin Shautsou <[email protected]>
@@ -90,8 +90,15 @@ public void setConfigs(List<GitHubServerConfig> configs) { | |||
return configs; | |||
} | |||
|
|||
/** | |||
* @deprecated get GitHubServerConfig matching to exact remote GH server, filter and only then check allowToManage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this method exists only to check - can we ever manage hooks somewhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it useless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, we can skip some actions if no any server is allowed to manage hooks (such as cleanup)
should be notice, not deprecation |
Relying on this manageHooks may end to situation that it will try register hook for GH server that has disabled hooks.
PS One line fluent is hardly readable for eyes.
This change is