Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX JENKINS-60017 #24

Merged
merged 2 commits into from
Nov 1, 2021
Merged

FIX JENKINS-60017 #24

merged 2 commits into from
Nov 1, 2021

Conversation

mecseid
Copy link
Contributor

@mecseid mecseid commented Jun 13, 2020

@lkraider
Copy link

Does this address https://issues.jenkins-ci.org/browse/JENKINS-62326 as well?

@mecseid
Copy link
Contributor Author

mecseid commented Jun 23, 2020

No, it doesn't. I will check that issue too, but I need some time to figure out how does it work. :)

@Saltari
Copy link

Saltari commented Jan 8, 2021

When can we expect this to land in the 1.2.2 version of the plugin ?

@mecseid
Copy link
Contributor Author

mecseid commented Jan 8, 2021

As far as I know, @stephenc is the only maintaner at the moment, so ping him for further information.

@Saltari
Copy link

Saltari commented Jan 8, 2021

Thanks @mecseid for your quick answer. @stephenc this PR would help many who do not have admin access to a gitea organisation. A follow-up on this would be awesome !

@justusbunsi
Copy link
Member

justusbunsi commented May 11, 2021

Any updates on this @stephenc?

justusbunsi pushed a commit to justusbunsi/gitea-plugin that referenced this pull request Aug 29, 2021
@lafriks
Copy link
Contributor

lafriks commented Oct 27, 2021

please resolve conflicts

@lafriks lafriks added the bug label Oct 27, 2021
@mecseid
Copy link
Contributor Author

mecseid commented Oct 28, 2021

It's hard to test and the whole class looks a bit messy for me, but rebased to the main, so @lafriks please review the PR.

@justusbunsi justusbunsi added this to the 1.4.0 milestone Oct 31, 2021
@justusbunsi
Copy link
Member

Although I wasn't able to reproduce the issue anymore with the latest master/main build and a Gitea instance >v1.12.0, I could verify that this will fix builds for pull requests on Gitea instanced with older versions than 1.12.0.

The plugin aims to work with no specific Gitea versions, so it might be good to merge this even in 2021 with a latest Gitea version of v1.15.x.

@justusbunsi justusbunsi merged commit 42157be into jenkinsci:master Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants