Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to go 1.22 #448

Merged
merged 3 commits into from
Jun 5, 2024
Merged

chore: upgrade to go 1.22 #448

merged 3 commits into from
Jun 5, 2024

Conversation

msvticket
Copy link
Member

related to jenkins-x/jx#8670

@jenkins-x-bot
Copy link

[jx-info] Hi, we've detected that the pipelines in this repository are using a syntax that will soon be deprecated.
We'll continue to update you through PRs as we progress. Please check #8589 for further information.

@msvticket
Copy link
Member Author

/retest

@msvticket
Copy link
Member Author

@jenkins-x-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: garethjevans

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit b6e67c8 into main Jun 5, 2024
2 of 3 checks passed
@vdemeester
Copy link

@msvticket @garethjevans any reason to use 1.22.3 over 1.22 ? This "kind-of" causes issues for projects depending on it but using go 1.22 as the version instead (like tektoncd/pipeline).

 go: github.com/jenkins-x/go-scm in vendor/modules.txt requires go >= 1.22.3 (running go 1.22.1) 

@msvticket
Copy link
Member Author

@msvticket @garethjevans any reason to use 1.22.3 over 1.22 ? This "kind-of" causes issues for projects depending on it but using go 1.22 as the version instead (like tektoncd/pipeline).

 go: github.com/jenkins-x/go-scm in vendor/modules.txt requires go >= 1.22.3 (running go 1.22.1) 

In practice I think it was because Intellij set that automatically. But if it causes problems you can make a PR to change it.

@garethjevans garethjevans deleted the go1-22 branch June 10, 2024 10:48
@vdemeester
Copy link

In practice I think it was because Intellij set that automatically. But if it causes problems you can make a PR to change it.

Alright, perfect. I'll check something and will raise a PR if I can't get around it 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants