Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version of golang used for testing #436

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

waciumawanjohi
Copy link

Testing (running go test ./...) with go 1.18 fails with message

# github.com/go-git/go-git/v5/utils/trace
../../../go/pkg/mod/github.com/go-git/go-git/[email protected]/utils/trace/trace.go:15:17: undefined: atomic.Int32
note: module requires Go 1.19

Testing with go 1.21 or 1.22 fails with the message:

go: updates to go.mod needed; to update it:
	go mod tidy

Running go mod tidy -go=1.19 yields:

go: k8s.io/[email protected] requires [email protected], but 1.19 is requested

Running go mod tidy without specifying the version bumps the go version and go toolchain version. Running make lint after this causes a panic.

This PR simply bumps the go version for running tests to 1.20 to enable unrelated changes to be merged.

@jenkins-x-bot
Copy link

Hi @waciumawanjohi. Thanks for your PR.

I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@garethjevans
Copy link
Member

/ok-to-test

@msvticket
Copy link
Member

/retest

@garethjevans
Copy link
Member

/lgtm

@jenkins-x-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: garethjevans

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit 1e8a189 into jenkins-x:main Apr 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants