fix(stash): first push not triggering postsubmits in lighthouse #385
Conversation
|
Hi @helmlover. Thanks for your PR. I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. |
|
/assign @babadofar |
|
Since Atlassian decided to not support the Server Version of BitBucket Server (https://www.atlassian.com/migration/assess/journey-to-cloud ), I believe that this is the last chance for this fix. Since Server will not change any more in my opinion this is the only way to make this working safely. |
|
@helmlover would you be able to rebase this one to avoid the merge conflicts? |
gerrnot
force-pushed
the
fix/stash/first-branch-push-event-triggers-no-build
branch
from
19adce0
to
9af00ef
Compare
|
@garethjevans updated |
|
/ok-to-test |
|
/test lint |
|
@garethjevans Thx for the ok-to-test label! However, linting seems to fail and I get a basic auth screen when opening the url. Could you just tell if there is anything I can do about it? |
helmlover
changed the title
|
/test lint |
|
/assign @garethjevans |
gerrnot
force-pushed
the
fix/stash/first-branch-push-event-triggers-no-build
branch
3 times, most recently
from
10271d1
to
3315f95
Compare
|
Just rebased this PR, but still cannot access (see) the lint job failures. Would be glad if somebody with permissions could help out here. |
|
/retest |
|
The pr pipeline is failing with: Do rebase the PR on main, run |
gerrnot
force-pushed
the
fix/stash/first-branch-push-event-triggers-no-build
branch
2 times, most recently
from
3f5ca6c
to
474efbe
Compare
|
The default pipelines doesn't support go 1.21. So the easiest route for you is to let the go version stay at 1.19 for now. |
gerrnot
force-pushed
the
fix/stash/first-branch-push-event-triggers-no-build
branch
2 times, most recently
from
5bbfc6a
to
405c2b3
Compare
gerrnot
force-pushed
the
fix/stash/first-branch-push-event-triggers-no-build
branch
2 times, most recently
from
e74d59a
to
4dab220
Compare
… on bitbucket server)
* treats branch ADD event as push event
-> the ADD event is almost identical to the UPDATE event which already get classified as push event
* lighthouse currently does not handle branch events (only push events) - for any provider:
```
func (s *Server) handleBranchEvent(entry *logrus.Entry, hook *scm.BranchHook) {
// TODO
}
```
gerrnot
force-pushed
the
fix/stash/first-branch-push-event-triggers-no-build
branch
from
4dab220
to
cba2298
Compare
|
Figured out that the linting could be triggered locally as well ( |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msvticket The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Problem
You configure a postsubmit for a given branch and expect lighthouse to execute a pipeline for you.
However, for bitbucket (stash implementations) this does not work for the first push event of a branch.
That is because the first push event (unless subsequent ones, which get classified as push event) got classified as branch event.
However, branch events are not implemented by lighthouse, and therefore get ignored:
Solution
The problem, gets fixed by this PR, which classifies the first branch push event also as push event, which can be well processed by ligththouse.