gitlab: AddCollaborator tell when user is a member

[manuelstein]

Fixing AddCollaborator to tell when a user is already a member:

• response 409 Conflict signals user having already been a member
  GitLab doesn't implement the invite/accept workflow:
• successfully adding a member also reports it as being a member

This is to prevent client code continuing with the invite/accept workflow after calling AddCollaborator.
E.g. jenkins-x-plugins/jx-project#454

[jenkins-x-bot]

Hi @manuelstein. Thanks for your PR.

I'm waiting for a jenkins-x or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

[LinuxSuRen]

hi @manuelstein you might just forget to get check the ci status. Please take a look at it.

[manuelstein]

what is "check ci status" even supposed to mean in this context? In case of GitLab, the SCM client returns an error with the 409 status, meaning the user is already a member and the code fails the task at this point.

[msvticket]

If you make the commit message conform to semantic commit messages we can get this merged

/ok-to-test
/assign

[msvticket]

/approve

[jenkins-x-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msvticket

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [msvticket]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jenkins-x-bot]

@manuelstein: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
lint	3bfe234	link	/test lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

[LinuxSuRen]

Confused about this.

[manuelstein]

If you make the commit message conform to semantic commit messages we can get this merged

/ok-to-test /assign

Ah, so it was all about the commit msg not following semver 😌
Sorry, @LinuxSuRen, I couldn't find anything that tells me what's wrong with the PR, so I kind of related your comment to the code change and it just didn't make sense 😊
As third party, I can't access the CI dashboard, e.g. the lint job failing above points to http:https://dashboard-jx.infra.jenkins-x.rocks/namespaces/jx/pipelineruns/jenkins-x-go-scm-pr-299-lint-kvjjp which requires authentication.