Pass status code on http error

Current implementation fails to pass error messages back to users in the
case of some errors, notably 403 errors from gitlab. This commit borrows
the http error handling from the gitea driver and applies the
pattern to all of the other drivers.

scm/driver/bitbucket/bitbucket.go

@@ -9,7 +9,9 @@ import (
  "bytes"
  "context"
  "encoding/json"
+ "errors"
  "io"
+ "net/http"
  "net/url"
  "strings"
 
@@ -90,9 +92,9 @@ func (c *wrapper) do(ctx context.Context, method, path string, in, out interface
  if res.Status == 401 {
  return res, scm.ErrNotAuthorized
  } else if res.Status > 300 {
- err := new(Error)
- json.NewDecoder(res.Body).Decode(err) // #nosec
- return res, err
+ return res, errors.New(
+  http.StatusText(res.Status),
+ )
  }
 
  if out == nil {

scm/driver/github/github.go

@@ -9,6 +9,7 @@ import (
  "bytes"
  "context"
  "encoding/json"
+ "errors"
  "fmt"
  "net/http"
  "net/url"
@@ -159,9 +160,9 @@ func (c *wrapper) doRequest(ctx context.Context, req *scm.Request, in, out inter
  if res.Status == 404 {
  return res, scm.ErrNotFound
  }
- err := new(Error)
- json.NewDecoder(res.Body).Decode(err)
- return res, err
+ return res, errors.New(
+  http.StatusText(res.Status),
+ )
  }
 
  if out == nil {

scm/driver/gitlab/gitlab.go

@@ -9,6 +9,7 @@ import (
  "bytes"
  "context"
  "encoding/json"
+ "errors"
  "fmt"
  "net/http"
  "net/url"
@@ -163,9 +164,9 @@ func (c *wrapper) do(ctx context.Context, method, path string, in, out interface
  // if an error is encountered, unmarshal and return the
  // error response.
  if res.Status > 300 {
- err := new(Error)
- json.NewDecoder(res.Body).Decode(err)
- return res, err
+ return res, errors.New(
+  http.StatusText(res.Status),
+ )
  }
 
  if out == nil {