add ListedIssueEvent API

scm/driver/bitbucket/issue.go

@@ -14,6 +14,10 @@ type issueService struct {
  client *wrapper
 }
 
+func (s *issueService) ListEvents(context.Context, string, int, scm.ListOptions) ([]*scm.ListedIssueEvent, *scm.Response, error) {
+ panic("implement me")
+}
+
 func (s *issueService) ListLabels(context.Context, string, int, scm.ListOptions) ([]*scm.Label, *scm.Response, error) {
  panic("implement me")
 }

scm/driver/fake/data.go

@@ -12,13 +12,12 @@ type Data struct {
  PullRequestChanges map[int][]*scm.Change
  PullRequestComments map[int][]*scm.Comment
  ReviewID int
- Reviews map[int][]scm.Review
+ Reviews map[int][]*scm.Review
  // TODO
  //CombinedStatuses map[string]*github.CombinedStatus
  CreatedStatuses map[string][]scm.Status
- // TODO
- // IssueEvents map[int][]github.ListedIssueEvent
- Commits map[string]scm.CommitTree
+ IssueEvents map[int][]*scm.ListedIssueEvent
+ Commits map[string]scm.CommitTree
 
  //All Labels That Exist In The Repo
  RepoLabelsExisting []string
@@ -65,8 +64,9 @@ func NewData() *Data {
  PullRequests: map[int]*scm.PullRequest{},
  PullRequestChanges: map[int][]*scm.Change{},
  PullRequestComments: map[int][]*scm.Comment{},
- Reviews: map[int][]scm.Review{},
+ Reviews: map[int][]*scm.Review{},
  CreatedStatuses: map[string][]scm.Status{},
+ IssueEvents: map[int][]*scm.ListedIssueEvent{},
  Commits: map[string]scm.CommitTree{},
  MilestoneMap: map[string]int{},
  CommitMap: map[string][]scm.Commit{},

scm/driver/fake/fake.go

@@ -23,14 +23,14 @@ func NewDefault() (*scm.Client, *Data) {
 
  client.Repositories = &repositoryService{client: client, data: data}
  client.Issues = &issueService{client: client, data: data}
+ client.PullRequests = &pullService{client: client, data: data}
+ client.Reviews = &reviewService{client: client, data: data}
 
  // TODO
  /*
  client.Contents = &contentService{client}
  client.Git = &gitService{client}
  client.Organizations = &organizationService{client}
- client.PullRequests = &pullService{&issueService{client}}
- client.Reviews = &reviewService{client}
  client.Users = &userService{client}
  client.Webhooks = &webhookService{client}
  */

scm/driver/fake/issue.go

@@ -17,6 +17,11 @@ type issueService struct {
 
 const botName = "k8s-ci-robot"
 
+func (s *issueService) ListEvents(ctx context.Context, repo string, number int, opts scm.ListOptions) ([]*scm.ListedIssueEvent, *scm.Response, error) {
+ f := s.data
+ return append([]*scm.ListedIssueEvent{}, f.IssueEvents[number]...), nil, nil
+}
+
 func (s *issueService) Find(ctx context.Context, repo string, number int) (*scm.Issue, *scm.Response, error) {
  f := s.data
  for _, slice := range f.Issues {
@@ -122,8 +127,9 @@ func (s *issueService) List(context.Context, string, scm.IssueListOptions) ([]*s
  panic("implement me")
 }
 
-func (s *issueService) ListComments(context.Context, string, int, scm.ListOptions) ([]*scm.Comment, *scm.Response, error) {
- panic("implement me")
+func (s *issueService) ListComments(ctx context.Context, repo string, number int, opts scm.ListOptions) ([]*scm.Comment, *scm.Response, error) {
+ f := s.data
+ return append([]*scm.Comment{}, f.IssueComments[number]...), nil, nil
 }
 
 func (s *issueService) Create(context.Context, string, *scm.IssueInput) (*scm.Issue, *scm.Response, error) {
@@ -132,7 +138,7 @@ func (s *issueService) Create(context.Context, string, *scm.IssueInput) (*scm.Is
 
 func (s *issueService) CreateComment(ctx context.Context, repo string, number int, comment *scm.CommentInput) (*scm.Comment, *scm.Response, error) {
  f := s.data
- f.IssueCommentsAdded = append(f.IssueCommentsAdded, fmt.Sprintf("%s#%d:%s", repo, number, comment))
+ f.IssueCommentsAdded = append(f.IssueCommentsAdded, fmt.Sprintf("%s#%d:%s", repo, number, comment.Body))
  answer := &scm.Comment{
  ID: f.IssueCommentID,
  Body: comment.Body,
@@ -143,8 +149,18 @@ func (s *issueService) CreateComment(ctx context.Context, repo string, number in
  return answer, nil, nil
 }
 
-func (s *issueService) DeleteComment(context.Context, string, int, int) (*scm.Response, error) {
- panic("implement me")
+func (s *issueService) DeleteComment(ctx context.Context, repo string, number int, id int) (*scm.Response, error) {
+ f := s.data
+ f.IssueCommentsDeleted = append(f.IssueCommentsDeleted, fmt.Sprintf("%s#%d", repo, id))
+ for num, ics := range f.IssueComments {
+ for i, ic := range ics {
+ if ic.ID == id {
+ f.IssueComments[num] = append(ics[:i], ics[i+1:]...)
+ return nil, nil
+ }
+ }
+ }
+ return nil, fmt.Errorf("could not find issue comment %d", id)
 }
 
 func (s *issueService) Close(context.Context, string, int) (*scm.Response, error) {

scm/driver/fake/pr.go

@@ -0,0 +1,50 @@
+package fake
+
+import (
+ "context"
+
+ "github.com/jenkins-x/go-scm/scm"
+)
+
+type pullService struct {
+ client *wrapper
+ data *Data
+}
+
+func (s *pullService) Find(context.Context, string, int) (*scm.PullRequest, *scm.Response, error) {
+ panic("implement me")
+}
+
+func (s *pullService) FindComment(context.Context, string, int, int) (*scm.Comment, *scm.Response, error) {
+ panic("implement me")
+}
+
+func (s *pullService) List(context.Context, string, scm.PullRequestListOptions) ([]*scm.PullRequest, *scm.Response, error) {
+ panic("implement me")
+}
+
+func (s *pullService) ListChanges(ctx context.Context, repo string, number int, opts scm.ListOptions) ([]*scm.Change, *scm.Response, error) {
+ f := s.data
+ return f.PullRequestChanges[number], nil, nil
+}
+
+func (s *pullService) ListComments(ctx context.Context, repo string, number int, opts scm.ListOptions) ([]*scm.Comment, *scm.Response, error) {
+ f := s.data
+ return append([]*scm.Comment{}, f.PullRequestComments[number]...), nil, nil
+}
+
+func (s *pullService) Merge(context.Context, string, int) (*scm.Response, error) {
+ panic("implement me")
+}
+
+func (s *pullService) Close(context.Context, string, int) (*scm.Response, error) {
+ panic("implement me")
+}
+
+func (s *pullService) CreateComment(context.Context, string, int, *scm.CommentInput) (*scm.Comment, *scm.Response, error) {
+ panic("implement me")
+}
+
+func (s *pullService) DeleteComment(context.Context, string, int, int) (*scm.Response, error) {
+ panic("implement me")
+}

scm/driver/fake/review.go

@@ -0,0 +1,46 @@
+package fake
+
+import (
+ "context"
+
+ "github.com/jenkins-x/go-scm/scm"
+)
+
+type reviewService struct {
+ client *wrapper
+ data *Data
+}
+
+func (s *reviewService) Find(ctx context.Context, repo string, number int, reviewID int) (*scm.Review, *scm.Response, error) {
+ reviews, r, err := s.List(ctx, repo, number, scm.ListOptions{})
+ if err != nil {
+ return nil, r, err
+ }
+ for _, review := range reviews {
+ if review.ID == reviewID {
+ return review, nil, nil
+ }
+ }
+ return nil, r, err
+}
+
+func (s *reviewService) List(ctx context.Context, repo string, number int, opt scm.ListOptions) ([]*scm.Review, *scm.Response, error) {
+ f := s.data
+ return append([]*scm.Review{}, f.Reviews[number]...), nil, nil
+}
+
+func (s *reviewService) Create(ctx context.Context, repo string, number int, input *scm.ReviewInput) (*scm.Review, *scm.Response, error) {
+ f := s.data
+ review := &scm.Review{
+ ID: f.ReviewID,
+ Author: scm.User{Login: botName},
+ Body: input.Body,
+ }
+ f.Reviews[number] = append(f.Reviews[number], review)
+ f.ReviewID++
+ return review, nil, nil
+}
+
+func (s *reviewService) Delete(context.Context, string, int, int) (*scm.Response, error) {
+ panic("implement me")
+}

scm/driver/gitea/issue.go

@@ -16,6 +16,10 @@ type issueService struct {
  client *wrapper
 }
 
+func (s *issueService) ListEvents(context.Context, string, int, scm.ListOptions) ([]*scm.ListedIssueEvent, *scm.Response, error) {
+ panic("implement me")
+}
+
 func (s *issueService) ListLabels(context.Context, string, int, scm.ListOptions) ([]*scm.Label, *scm.Response, error) {
  panic("implement me")
 }

scm/driver/github/issue.go

@@ -62,6 +62,13 @@ func (s *issueService) ListLabels(ctx context.Context, repo string, number int,
  return convertLabelObjects(out), res, err
 }
 
+func (s *issueService) ListEvents(ctx context.Context, repo string, number int, opts scm.ListOptions) ([]*scm.ListedIssueEvent, *scm.Response, error) {
+ path := fmt.Sprintf("repos/%s/issues/%d/events?%s", repo, number, encodeListOptions(opts))
+ out := []*listedIssueEvent{}
+ res, err := s.client.do(ctx, "GET", path, nil, &out)
+ return convertListedIssueEvents(out), res, err
+}
+
 func (s *issueService) AddLabel(ctx context.Context, repo string, number int, label string) (*scm.Response, error) {
  path := fmt.Sprintf("repos/%s/issues/%d/labels", repo, number)
  in := []string{label}
@@ -153,6 +160,15 @@ type issueCommentInput struct {
  Body string `json:"body"`
 }
 
+// listedIssueEvent represents an issue event from the events API (not from a webhook payload).
+// https://developer.github.com/v3/issues/events/
+type listedIssueEvent struct {
+ Event string `json:"event"` // This is the same as IssueEvent.Action.
+ Actor user `json:"actor"`
+ Label label `json:"label"`
+ Created time.Time `json:"created_at"`
+}
+
 // helper function to convert from the gogs issue list to
 // the common issue structure.
 func convertIssueList(from []*issue) []*scm.Issue {
@@ -231,3 +247,20 @@ func convertLabelObjects(from []*label) []*scm.Label {
  }
  return labels
 }
+
+func convertListedIssueEvents(src []*listedIssueEvent) []*scm.ListedIssueEvent {
+ var answer []*scm.ListedIssueEvent
+ for _, from := range src {
+ answer = append(answer, convertListedIssueEvent(from))
+ }
+ return answer
+}
+
+func convertListedIssueEvent(from *listedIssueEvent) *scm.ListedIssueEvent {
+ return &scm.ListedIssueEvent{
+ Event: from.Event,
+ Actor: *convertUser(&from.Actor),
+ Label: convertLabel(from.Label),
+ Created: from.Created,
+ }
+}

scm/driver/gitlab/issue.go

@@ -18,6 +18,10 @@ type issueService struct {
  client *wrapper
 }
 
+func (s *issueService) ListEvents(context.Context, string, int, scm.ListOptions) ([]*scm.ListedIssueEvent, *scm.Response, error) {
+ panic("implement me")
+}
+
 func (s *issueService) ListLabels(context.Context, string, int, scm.ListOptions) ([]*scm.Label, *scm.Response, error) {
  panic("implement me")
 }

scm/driver/gogs/issue.go

@@ -16,6 +16,10 @@ type issueService struct {
  client *wrapper
 }
 
+func (s *issueService) ListEvents(context.Context, string, int, scm.ListOptions) ([]*scm.ListedIssueEvent, *scm.Response, error) {
+ panic("implement me")
+}
+
 func (s *issueService) ListLabels(context.Context, string, int, scm.ListOptions) ([]*scm.Label, *scm.Response, error) {
  panic("implement me")
 }

scm/driver/stash/issue.go

@@ -14,6 +14,10 @@ type issueService struct {
  client *wrapper
 }
 
+func (s *issueService) ListEvents(context.Context, string, int, scm.ListOptions) ([]*scm.ListedIssueEvent, *scm.Response, error) {
+ panic("implement me")
+}
+
 func (s *issueService) ListLabels(context.Context, string, int, scm.ListOptions) ([]*scm.Label, *scm.Response, error) {
  panic("implement me")
 }

scm/issue.go

@@ -59,6 +59,14 @@ type (
  Body string
  }
 
+ // ListedIssueEvent for listing events on an issue
+ ListedIssueEvent struct {
+ Event string
+ Actor User
+ Label Label
+ Created time.Time
+ }
+
  // IssueService provides access to issue resources.
  IssueService interface {
  // Find returns the issue by number.
@@ -76,6 +84,9 @@ type (
  // ListLabels returns the labels on an issue
  ListLabels(context.Context, string, int, ListOptions) ([]*Label, *Response, error)
 
+ // ListEvents returns the labels on an issue
+ ListEvents(context.Context, string, int, ListOptions) ([]*ListedIssueEvent, *Response, error)
+
  // Create creates a new issue.
  Create(context.Context, string, *IssueInput) (*Issue, *Response, error)