Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to the latest Pulumi and simplify where possible #7

Merged
merged 6 commits into from
Sep 15, 2018

Conversation

jen20
Copy link
Owner

@jen20 jen20 commented Sep 15, 2018

@pulumi/pulumi v0.15.2 and @pulumi/aws v0.15.1 bring in some improvements to the way IAM documents are handled, and bring a well-known type for AWS tags.

This pull request updates this module to take advantage of those features, such that we don't have to Stringify policy documents or write role assumption policies by hand.

In addition, zoneName is made optional, and a private hosted zone is not created for the VPC if it is not specified.

@jen20 jen20 added the enhancement New feature or request label Sep 15, 2018
@jen20 jen20 self-assigned this Sep 15, 2018
@jen20
Copy link
Owner Author

jen20 commented Sep 15, 2018

I tested this using the example in the README, and as second example with the zoneName removed, and all seems well in us-west-2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant