Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for use with Pulumi v3 & Add VPC Flow Logging to S3 #26

Merged
merged 4 commits into from
Aug 27, 2021
Merged

Update for use with Pulumi v3 & Add VPC Flow Logging to S3 #26

merged 4 commits into from
Aug 27, 2021

Conversation

doransmestad
Copy link

First off, thanks for this pulumi library @jen20! Very helpful getting a new VPC spun up.

This pull request contributes back a few things I needed:

  1. Allows use with Pulumi v3 and the pulumi-aws library v4 by changing the dependency requirements in setup.py
  2. Adds the ability to send VPC flow logs to a specified S3 bucket (it assumes the bucket is separately configured).
  3. Removes the extra dollar signs in the route table and subnet table Name tags

Thoughts?

@jen20 jen20 merged commit f51aa56 into jen20:master Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@doransmestad @jen20