Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix installation for Python locally and from Pypi #20

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Fix installation for Python locally and from Pypi #20

merged 1 commit into from
Apr 30, 2020

Conversation

jen20
Copy link
Owner

@jen20 jen20 commented Apr 30, 2020

Two issues existed with the Python package setup:

  • Hardcoding the path to ../README.md fails when installing from a package, but not using Pipenv local paths
  • We still required Pandoc despite using text/markdown as our long description format.

This PR fixes both issues.

@jen20 jen20 added the bug Something isn't working label Apr 30, 2020
@jen20 jen20 self-assigned this Apr 30, 2020
@jen20 jen20 merged commit 7224675 into master Apr 30, 2020
@jen20 jen20 deleted the jen20/fix-python-installation branch April 30, 2020 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jen20 jen20

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jen20