You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This issue was caused by us doing the user flag check during playlist creation, rather than when an episode has ended. Fixing this will simultaneously fix the player automatically playing the next episode with the flag Play next episode automatically disabled and allow proper usage of the skip to next/previous buttons for people with this flag disabled.
Changes
Moved checking the user setting flag from where the playlist is loaded to where we attempt to load the next episode after playback has been stopped (ie reaching the end of an episode).
The commit has now become complex/non-atomic.
I would just ignore SonarCloud - it was not relevant to your changes.
At the very least, the refactoring should be done in a separate commit.
The commit has now become complex/non-atomic. I would just ignore SonarCloud - it was not relevant to your changes. At the very least, the refactoring should be done in a separate commit.
I put it in a separate commit. If you still would rather I drop it altogether I can do that
Little note:
You must refresh the web client for the changes to take effect. Play next episode automatically is stored in the user configuration, which is cached by ApiClient, but the cache is not updated when the configuration is sent to the server.
We could fix this in ApiClient, but it is frozen/archived. So it is better to just migrate the playback settings to the new SDK (not in this PR).
thornbill
changed the title
Fix incorrect flag check preventing expected behavior when navigating to next episode
Fix play next when autoplay is disabled
Apr 30, 2024
bugSomething isn't workingenhancementImprove existing functionality or small fixesplaybackThis PR or issue mainly concerns playback
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConnorS1110
force-pushed
the
fix-broken-next-episode-setting
branch
2 times, most recently
from
nielsvanvelzen
added
bug
thornbill
changed the title
This issue was caused by us doing the user flag check during playlist creation, rather than when an episode has ended. Fixing this will simultaneously fix the player automatically playing the next episode with the flag
Play next episode automaticallydisabled and allow proper usage of the skip to next/previous buttons for people with this flag disabled.Changes
Moved checking the user setting flag from where the playlist is loaded to where we attempt to load the next episode after playback has been stopped (ie reaching the end of an episode).
Issues
Fixes #5382
Fixes #2596