Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite connection screen in Jetpack Compose #800

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

Maxr1998
Copy link
Member

Already somewhat ready for review, but I need to look at it another time tomorrow and might want to do some more testing.

@Maxr1998 Maxr1998 added the enhancement New feature or request label Sep 21, 2022
@Maxr1998 Maxr1998 added this to the v2.5.0 milestone Sep 21, 2022
android:id="@+id/compose_view"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:background="@color/theme_background" />

Check warning

Code scanning / Android Lint

Overdraw: Painting regions more than once

Possible overdraw: Root element paints background @color/theme_background with a theme that also paints a background (inferred theme is @style/AppTheme)
app/src/main/res/values/strings.xml Fixed Show fixed Hide fixed
app/src/main/res/values/strings.xml Fixed Show fixed Hide fixed
app/src/main/res/values/strings.xml Fixed Show fixed Hide fixed
app/src/main/res/values/strings.xml Fixed Show fixed Hide fixed
app/src/main/res/values/strings.xml Fixed Show fixed Hide fixed
@Maxr1998 Maxr1998 force-pushed the connect-fragment-compose branch 3 times, most recently from 6dbe848 to 5ecdc47 Compare September 21, 2022 16:29
@Maxr1998 Maxr1998 marked this pull request as ready for review September 21, 2022 16:30
gradle/libs.versions.toml Outdated Show resolved Hide resolved
app/src/main/res/values/strings_donottranslate.xml Outdated Show resolved Hide resolved
gradle/libs.versions.toml Outdated Show resolved Hide resolved
Copy link
Member

@nielsvanvelzen nielsvanvelzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yolo

@nielsvanvelzen nielsvanvelzen merged commit 6b9bb09 into master Sep 21, 2022
@nielsvanvelzen nielsvanvelzen deleted the connect-fragment-compose branch September 21, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants