Remove /feed.xml #182
Closed
Remove /feed.xml #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
It's also
|
|
I'd support removing the feed in a new major release, but would propose making the graceful fix in #129 for new users of the current version. |
DirtyF
previously approved these changes
Jan 16, 2018
fixed in #183 |
|
Thanks for merging #141, the social links changes, before this one. Apologies for it causing conflicts with feed.xml removal. |
- /feed.xml link is broken - minima doesn't generate any feed out of the box - minima doesn't depend on jekyll-feed - minima is "supposed to be minimal"
|
Rebased after #141 , no problems |
Jekyll is also great for static websites generally, which have no need for a feed. Unfortunately, finding out how many Jekyll users use |
|
Link to feed has been fixed in #183 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #129 and #98.