Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3146: Integrate 'UserMenu' with 'NavBar' #3147

Merged
merged 27 commits into from
Dec 16, 2017
Merged

#3146: Integrate 'UserMenu' with 'NavBar' #3147

merged 27 commits into from
Dec 16, 2017

Conversation

jeff1evesque
Copy link
Owner

Resolves #3146.

@jeff1evesque
#3146: package.json, add 'rearm'
c55aca4
@jeff1evesque
#3146: breakpoints.js, create file
3e959e9
@jeff1evesque
#3146: analysis.jsx, conditionally render breakpoints
e53a99d
@jeff1evesque
#3146: analysis.jsx, move button, submitBtn, resultBtn
b44b9ae
@jeff1evesque
#3146: analysis.jsx, relocate docstring
5e6cc04
@jeff1evesque
#3146: analysis.jsx, adjust inline docstring
d5eef89
@jeff1evesque
#3146: analysis.jsx, use 'import from'
04f9220
@jeff1evesque
#3146: analysis.jsx, wrap adjacent jsx elements
91a5ccc
@jeff1evesque
#3146: analysis.jsx, adjust ternary, and jsx wrapper
680c15d
@jeff1evesque
#3146: adjust 'breakpoints', reference 'small'
371d728
@jeff1evesque
#3146: user-menu.jsx, add another 'Nav pullright'
2d4b9a6
@jeff1evesque
#3146: user-menu.jsx, remove 'eventKey'
e579200
@jeff1evesque
#3146: analysis.jsx, segregate mobile + desktop view
201b051
@jeff1evesque
#3146: header-menu.jsx, conditionally render menu
4de8d08
@jeff1evesque
#3146: analysis.jsx, add trivial space character
4bb7b51
@jeff1evesque
#3146: header-menu.jsx, import 'SvgHome', and 'Link'
7cfe98c
@jeff1evesque
#3146: header-menu.jsx, import 'LinkContainer'
68ef3da
@jeff1evesque
#3146: header-menu.jsx, fix 'Generate model' typo
15e27fa
@jeff1evesque
#3146: _navigation.scss, 'margin' on 'menu-container'
54a47c5
@jeff1evesque
#3146: header-menu.jsx, rearragne 'LinkContainer'
1eb9211
@jeff1evesque
#3146: results.jsx, fix indentation
16e1514
@jeff1evesque
#3146: implement 'lcolumn' scss 'className'
7074e46
@jeff1evesque
#3146: breakpoints.js, approx bpoints like bootstrap
1c47d97
@jeff1evesque
#3146: header-menu.jsx, eliminate 'NavDropdown'
b1f64d9
@jeff1evesque jeff1evesque added this to the 0.7 milestone Dec 15, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 53.433% when pulling 1113f21 on feature-3146 into 285b673 on master.

@jeff1evesque
Copy link
Owner Author

The following are some rendered pages as an anonymous user:

anon-desktop

anon-mobile-1

anon-mobile-2

@jeff1evesque
Copy link
Owner Author

The following are some rendered pages as an authenticated user:

auth-desktop

auth-desktop-1

auth-desktop-2

auth-desktop-3

@coveralls
Copy link

Coverage Status

Coverage remained the same at 53.433% when pulling 106dd7e on feature-3146 into 285b673 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 53.433% when pulling 106dd7e on feature-3146 into 285b673 on master.

@jeff1evesque jeff1evesque merged commit b843469 into master Dec 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pull: reviewed
Projects
None yet
Milestone
0.7
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeff1evesque @coveralls