Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store): add asus #102

Merged
merged 6 commits into from
Sep 20, 2020
Merged

feat(store): add asus #102

merged 6 commits into from
Sep 20, 2020

Conversation

fmarvez
Copy link
Contributor

@fmarvez fmarvez commented Sep 20, 2020

Description

Adds the Asus company store for TUF models

Testing

NA

New dependencies

None

@fmarvez fmarvez requested a review from jef as a code owner September 20, 2020 13:38
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only thing is do you mind adding documentation to README.md and putting the masterList is lexicographical order?

Thanks!

@fmarvez fmarvez requested a review from jef September 20, 2020 14:05
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Looks great 😄

@jef jef changed the title Add Asus company store feat(store): add asus Sep 20, 2020
@jef jef merged commit a501cf7 into jef:main Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants