Presentation Layer for NPM Register #92
Conversation
Adding readme to the API response
| @@ -2,5 +2,5 @@ const app = require('./server') | |||
| const config = require('./config') | |||
|
|
|||
| app.listen(config.port, function () { | |||
| console.log(`${app.name} listening on port ${config.port} [${app.get('env')}]`) | |||
| console.error(`${app.name} listening on http:https://localhost:${config.port} [${app.get('env')}]`) | |||
There was a problem hiding this comment.
This should be log...oversight on my part.
|
I'll be revisiting this since I have time now. Sorry for the delay everyone. |
|
Well can we have this? This is a killer feature :) |
|
@holms yea i'm jumping back into this. stay tuned! |
|
I'm really glad you've did so much regarding this, would be nice to have some voice from maintainer. Also those CI tests are dead for a long time too. I can't even use this product in container got permission denied if using local fs. |
|
@dgautsch I've just submitted a PR, and seems to be tests are passing. Probably you're still on old pipeline task or something. I'd re-submit PR if I were you :) Because it's complains about AWS keys, which nowhere to be found in pipeline which been executed on my PR update: no, I recall my words, probably because app itself haven't been touched, so it doesn't trigger testing pipeline where it test S3 with AWS creds. |
|
Update on this: The only thing holding this back is the tarball from S3 isn't resolving. Works fine when running from the local filesystem. This only happens with namespaced packages. @jdxcode any idea what might be causing this? I was going to look more into this today. |
|
@jdxcode we want to progress with your beautiful registry :) |
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
=========================================
Coverage ? 85.86%
=========================================
Files ? 28
Lines ? 467
Branches ? 0
=========================================
Hits ? 401
Misses ? 66
Partials ? 0
Continue to review full report at Codecov.
|
|
Really waiting for this to be merged :) |
dgautsch
changed the title
This is my first pass at a UI.
Leveraged the Material UI react library to build this out. https://material-ui-1dab0.firebaseapp.com
Features included
To Do