Fix scope in redirect for bad paths #119
Conversation
Codecov Report
@@ Coverage Diff @@
## master #119 +/- ##
=========================================
+ Coverage 89.72% 90.43% +0.7%
=========================================
Files 27 27
Lines 438 439 +1
=========================================
+ Hits 393 397 +4
+ Misses 45 42 -3
Continue to review full report at Codecov.
|
|
Added tests and they all pass locally. |
lib/routes/tarballs.js
Outdated
| let url = `/${name}/-/${scope2}/${sha}` | ||
| // TODO: fix scoped packages | ||
| // if (scope) url = `/${scope}${url}` | ||
| let _scope = scope ? `/${scope}` : '' |
There was a problem hiding this comment.
Great fix, thanks Ian! Can we convert the let to a const as the value isn't reassigned. Also curious on the underscore naming convention. Are you denoting it's private?
There was a problem hiding this comment.
I just gave it an underscore because there is already a scope var. Ultimately it's still reflective of the scope so it made more sense to me to give it the underscore. I can call it something else to avoid confusion.
|
@dgautsch just updated it |
I don't know why this was commented out with a fix comment. It makes me wonder if this can have some side effects that i'm not expecting. I'm going to test it out on our side.