Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPM Installing packages 404's #129

Closed
dgautsch opened this issue Aug 31, 2018 · 1 comment
Closed

NPM Installing packages 404's #129

dgautsch opened this issue Aug 31, 2018 · 1 comment
Assignees
@dgautsch
Labels
bug
Milestone
v2.8.0

Comments

@dgautsch
Copy link
Collaborator

Found in version 2.7.1
@dgautsch dgautsch added the bug label Aug 31, 2018
@dgautsch dgautsch added this to the v2.8.0 milestone Aug 31, 2018
@dgautsch dgautsch self-assigned this Aug 31, 2018
@dgautsch dgautsch mentioned this issue Aug 31, 2018
Closed
@dgautsch
Copy link
Collaborator Author

Steps to Reproduce

  1. Run npm install axios --save
  2. Package 404's

Expected: Package should resolve

The response body for axios is a string and not an object like most packages. Putting a check in for this to parse it out.

dgautsch added a commit to dgautsch/npm-register that referenced this issue Aug 31, 2018
@dgautsch
Checking response body from npm then parsing as necessary Fix jdx#129
3d07ba9
@dgautsch dgautsch mentioned this issue Aug 31, 2018
Merged
dgautsch added a commit that referenced this issue Aug 31, 2018
@dgautsch
Fix/129 - Packages 404 (#130)
a91329c 
* Checking response body from npm then parsing as necessary Fix #129
@vazexqi vazexqi mentioned this issue Aug 31, 2018
Merged
DenizOkcu pushed a commit to DenizOkcu/npm-register that referenced this issue Sep 3, 2018
@dgautsch
Fix/129 - Packages 404 (jdx#130)
d1a42af 
* Checking response body from npm then parsing as necessary Fix jdx#129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgautsch dgautsch

Labels
bug
Projects
None yet
Milestone
v2.8.0
Development

No branches or pull requests
1 participant
@dgautsch