Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ./doc/config.md containing documentation for configuration options #19

Merged
merged 3 commits into from
May 16, 2019
Merged

Conversation

SirYodaJedi
Copy link
Contributor

Regarding #14.

@jdmclark
Copy link
Owner

Doc looks great.

Only comment about the PR is that the doc isn't linked anywhere. I think install.md (in the same directory) should be updated to link to this file. For example, wherever the install instructions mention "edit the config file", there should be a final bullet point that says something like "See the configuration guide for more information"

@SirYodaJedi
Copy link
Contributor Author

Okay, I added the links to the configuration guide in the installation guide.

@jdmclark
Copy link
Owner

Thanks for making those changes, @SirYodaJedi

@jdmclark jdmclark merged commit 31b3706 into jdmclark:master May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants