Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After program exits, The desktop resolution is set to 640x480 instead of 1080p. #33

Open
debrebeuf opened this issue Jun 21, 2019 · 14 comments
Labels
bug Something isn't working

Comments

@debrebeuf
Copy link

I did not see another issue related to this, so I think I might be the only one (given it is pretty big). The problem is on both JK and MotS. The video here speaks for itself:
https://youtu.be/feBl51qI6C0

Description:
"
Jedi Knight isn't flashy and weird like it is in the video, that is just obs doing its thing. That is not the problem.
The problem is that the display does not resume original size.
"
I used the cd-rom setup. The files I got are from GOG, but since my installation didn't come with JKStart.exe, I went with the other setup. I got the JK.exe straight from my original cd-rom and the program runs fine otherwise.

If I am the only one, it isn't a big deal. I could create a batch file to reset my screen size fairly easily. The only reason it is a hassle is because I make my own mods and levels, and they require debugging by opening and closing the program often, leaving me to reset my resolution everytime.

@SirYodaJedi
Copy link
Contributor

Hm, I don't have this problem. I have my game resolution set to 1440x1080, but it corrects back to 1920x1080 when exiting.

Out of curiosity, what is the resolution set to in jkgm.json?

@debrebeuf
Copy link
Author

debrebeuf commented Jun 22, 2019

Mine is set to 640x480 (for nostalgia).
But it does the same thing on all resolutions.

HOWEVER I made a batch file to fix this for now.
https://www.mediafire.com/file/a5darlhy9r7lbly/resfix.zip/file
If anybody needs it, here it is.
Read the README

@jdmclark
Copy link
Owner

Hi @debrebeuf

Thanks for reporting this issue. Unfortunately, I am not able to reproduce it. Could you please provide more information?

  • What version of Windows are you running?
  • What is your graphics adapter and driver version?
  • Do you have any compatibility options set for JK.exe?

Thanks

@debrebeuf
Copy link
Author

I am trying to run the game on my laptop.
I am running Windows 10 Home, Version 1803, OS build 17134.858 on the laptop.
The laptop uses integrated graphics, more specifically, Intel(R) HD Graphics 620.
Using DxDiagnostics, I retrieved that my driver version is 21.20.16.4599.
(I went to device manager to check if any driver updates were available, but none were)
There are no compatibility options set for JK.

Again, I might have a freak accident situation, and that's fine. Your program is cool enough as is in my opinion.

@jdmclark jdmclark added the bug Something isn't working label Jul 8, 2019
@mattolenik
Copy link

I'm getting this, too. My native res is 4K, I'm running in 1080p, and desktop resolution isn't restored after exiting. I'm also using the GOG version, but with an original JK.exe that was patched with the 2008 unofficial patch. I'd just run at 4K except I hit #9.

  • Radeon 5700XT, driver version 19.12.2
  • Windows 10.0.19536.1000 (Insider "fast" track)

@debrebeuf
Copy link
Author

If this means anything, I copied my exact files from my laptop that had this problem to my desktop and the problem remained. Because of this, my hunch is that maybe this has something to do with certain jk files being used and not graphics settings of Windows.

@jdmclark
Copy link
Owner

jdmclark commented Jan 12, 2020 via email

@mattolenik
Copy link

For what it's worth, I just tried again with the original JK.exe off an original disc. I had been using a prepatched version found online because my original discs were scratched up. After wetsanding to 8000 grit and finishing with plastic polish, I got them readable enough to get JK.exe off of disc 1. Sadly, no change in behavior.

@jdmclark
Copy link
Owner

Thanks @mattolenik

If possible, could you please list the DLL files in your JK directory?

The only other option I can think of would be a bad SDB. The Steam version is known to install one that makes bad changes to all JK exes (including from the CD). Checking this isn't as easy though: https://docs.microsoft.com/en-us/windows/deployment/planning/searching-for-fixed-applications-in-compatibility-administrator

@mattolenik
Copy link

Sure:

 512 Jan  6 20:13  Controls
 512 Jan  6 20:13  Episode
1.3M Jan  5 20:02  GOGLauncher.exe
236K Jan  5 20:35  JK-Extension.dll
1.4M Jan  5 20:35  JK.EXE
2.0K Jan  6 21:00  JK.lnk
864K Jan  5 20:00  JKStart.exe
210K Jan  5 20:01  Jedi.doc
1.7K Jan  5 20:01  Jedi.txt
1.1K Jan  5 20:08  LICENSE.md
1.6K Jan  5 20:03 'Launch STAR WARS® Jedi Knight - Dark Forces 2.lnk'
  62 Jan  6 21:28  Launch.bat
 512 Jan  6 20:13  MUSIC
2.1M Jan  5 20:03  Manual.pdf
 31K Jan  5 20:01  README.TXT
2.2K Jan  5 20:08  README.md
 512 Jan  6 20:13  Resource
 70K Jan  5 19:59  SMACKW32.DLL
3.5K Jan  5 20:08  THIRDPARTY.md
 673 Jan  5 20:01  UPDATE.TXT
 512 Jan  6 20:13  __support
 265 Jan  5 20:01  directplay.cmd
 512 Jan  6 20:13  doc
 608 Jan  5 20:01  game.sdb
 68K Sep 28  2017  gog.ico
1018 Jan  5 20:01  goggame-1422286819.hashdb
116K Jan  5 20:03  goggame-1422286819.ico
1.5K Jan  5 19:59  goggame-1422286819.info
 11K Jan  5 20:03  goggame-1422286819.script
2.6K Jan  5 20:03  goggame-galaxyFileList.ini
2.3K Jan  5 20:03  goglog.ini
179K Jan  5 20:08  inject.exe
 512 Jan  6 20:13  jkgm
 463 Jan 13 22:29  jkgm.json
 57K Jan  5 20:01  libogg-0.dll
175K Jan  5 20:02  libvorbis-0.dll
 46K Jan  5 20:00  libvorbisfile-3.dll
 512 Jan  7 00:07  player
396K Jan  5 20:08  renderer.dll
 62K Aug 26 18:19  support.ico
1.3M Jan  5 20:03  unins000.dat
1.3M Jan  5 20:03  unins000.exe
  41 Jan  5 20:03  unins000.ini
 23K Jan  5 20:03  unins000.msg
 64K Jan  5 20:00  winmm.dll

I tried again with a stripped down version of the GOG install and the original JK.exe, but no change.

    512 Jan 14 13:59 Controls
    512 Jan 14 13:59 Episode
1387520 Sep 11  1997 JK.EXE
    512 Jan 14 13:59 Resource
  71168 Jan  5 19:59 SMACKW32.DLL
 182784 Jan  5 20:08 inject.exe
    512 Jan 14 13:59 jkgm
    462 Jan 14 14:01 jkgm.json
    512 Jan 14 13:59 player
 404992 Jan  5 20:08 renderer.dll

@jdmclark
Copy link
Owner

Thanks.

Could you check one more thing, please? Does the same problem happen if you rename JK.EXE to something random - like foobar.exe? Making sure to also update jkgm.json with the new executable name.

@mattolenik
Copy link

mattolenik commented Jan 14, 2020

No luck, same thing :/ I also tried with and without the high DPI override set to Application. Without it, the whole thing was enormous but I was still able to get into the game. Same frame rate.

Edit: wait, I realize I was confusing these two issues. Let me try things again and get back to you.

@mattolenik
Copy link

I ran through the same process but this time checking for the resolution change rather than framerate like in #9. With the stripped down install and JK.exe renamed, the problem persists, resolution is still stuck after exiting.

@GeneralTantor
Copy link

I looked at the video its because you have this setting as true make it false and see what happens.
"correct_menu_aspect_ratio": false,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants