Skip to content

Commit

Permalink
no schemas, no time for that
Browse files Browse the repository at this point in the history
  • Loading branch information
ZanSara committed Mar 2, 2023
1 parent 7ec1d17 commit 747c067
Show file tree
Hide file tree
Showing 11 changed files with 10 additions and 1,082 deletions.
165 changes: 0 additions & 165 deletions .github/utils/generate_json_schema.py

This file was deleted.

78 changes: 10 additions & 68 deletions .github/workflows/test__text2speech.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,20 +26,21 @@ jobs:
with:
package: ${{ env.PACKAGE }}

- name: Install audio libraries
if: matrix.os == "ubuntu-latest"
run: |
sudo apt-get update
sudo apt-get install libsndfile1 ffmpeg
- name: Install dependencies
run: pip install ${{ env.PACKAGE }}[dev]

- name: Mypy
# NOTE: https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-library-stubs-or-py-typed-marker
# FIXME --install-types does not work properly yet, see https://github.com/python/mypy/issues/10600
# We should see if there's a better way than --ignore-missing-imports
run: mypy ${{ env.PACKAGE }} --ignore-missing-imports
if: steps.files.outputs.any_changed == 'true'
run: |
mkdir .mypy_cache/
mypy --install-types --non-interactive .
# - uses: act10ns/slack@v1
# with:
# status: ${{ job.status }}
# channel: '#haystack'
# if: failure() && github.repository_owner == 'deepset-ai' && github.ref == 'refs/heads/main'
pylint:
runs-on: ubuntu-latest
Expand All @@ -56,11 +57,6 @@ jobs:
cd ${{ env.PACKAGE }}
pylint -ry -j 0 text2speech/
# - uses: act10ns/slack@v1
# with:
# status: ${{ job.status }}
# channel: '#haystack'
# if: failure() && github.repository_owner == 'deepset-ai' && github.ref == 'refs/heads/main'
unit-tests:
name: Unit / ${{ matrix.os }}
Expand All @@ -86,11 +82,6 @@ jobs:
- name: Run
run: pytest ${{ env.PYTEST_PARAMS }} -m "unit" ${{ env.PACKAGE }}

# - uses: act10ns/slack@v1
# with:
# status: ${{ job.status }}
# channel: '#haystack'
# if: failure() && github.repository_owner == 'deepset-ai' && github.ref == 'refs/heads/main'

integration-tests:
name: Integration / ${{ matrix.os }}
Expand Down Expand Up @@ -124,52 +115,3 @@ jobs:
TOKENIZERS_PARALLELISM: 'false' # Avoid logspam by tokenizers
run: |
pytest ${{ env.PYTEST_PARAMS }} -m "integration" ${{ env.PACKAGE }}
# - uses: act10ns/slack@v1
# with:
# status: ${{ job.status }}
# channel: '#haystack'
# if: failure() && github.repository_owner == 'deepset-ai' && github.ref == 'refs/heads/main'


yaml-schema:
runs-on: ubuntu-latest
steps:

- uses: actions/checkout@v2

- name: Setup Python
uses: ./.github/actions/python_cache/
with:
package: ${{ env.PACKAGE }}

- name: Install sndfile
run: sudo apt update && sudo apt-get install libsndfile1 ffmpeg

- name: Install package
run: pip install -U ${{ env.PACKAGE }}[dev]

- name: Update pipeline YAML schemas
run: python .github/utils/generate_json_schema.py -o ${{ env.PACKAGE }}/json-schemas -v 0.0.1 -t "text2speech nodes schema" -d "schema for text2speech nodes" -p text2speech -m text2speech

- name: Check status
run: |
if [[ `git status --porcelain` ]]; then
git status
echo "##################################################################################################"
git diff
echo "##################################################################################################"
echo "# "
echo "# CHECK FAILED! The YAML schemas for this package were not updated."
echo "# "
echo "# Please generate the new schemas locally:"
echo "# "
echo "# python .github/utils/generate_json_schema.py -o ${{ env.PACKAGE }}/json-schemas -v 0.0.1 -t "text2speech nodes schema" -d "schema for text2speech nodes" -p text2speech -m text2speech"
echo "# "
echo "# Or see https://github.com/deepset-ai/haystack/blob/main/CONTRIBUTING.md for help."
echo "# "
echo "# If you have further problems, please open an issue: https://github.com/deepset-ai/haystack-extras/issues"
echo "# "
echo "##################################################################################################"
exit 1
fi
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,3 @@ repos:
hooks:
- id: mypy
files: nodes/text2speech/

- repo: local
hooks:
- id: yaml-schema
name: YAML Schema
entry: .github/utils/generate_json_schema.py --folder-name text2speech --module text2speech
language: script
types: [bash]
always_run: true

14 changes: 0 additions & 14 deletions json-schemas/haystack-extras.schema.json

This file was deleted.

41 changes: 0 additions & 41 deletions nodes/speech2text/.pre-commit-config.yaml

This file was deleted.

Loading

0 comments on commit 747c067

Please sign in to comment.