Skip to content

Commit

Permalink
Move duplicate thrift version constraint to Gemfile
Browse files Browse the repository at this point in the history
Prevents gem build if it is left in gemspec
  • Loading branch information
Ariel Salomon committed Nov 17, 2014
1 parent a8f83de commit 94f588c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
3 changes: 3 additions & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,6 @@ source 'https://rubygems.org'

# Specify your gem's dependencies in faraday-zipkin.gemspec
gemspec

# 0.9.1 adds thin dependency, prevents test on jruby
gem 'thrift', '0.9.0'
3 changes: 0 additions & 3 deletions faraday-zipkin.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,4 @@ Gem::Specification.new do |spec|
spec.add_development_dependency "bundler", "~> 1.6"
spec.add_development_dependency "rake", "~> 10.0"
spec.add_development_dependency "rspec", "~> 3.0"

# 0.9.1 adds thin dependency, prevents test on jruby
spec.add_development_dependency "thrift", "0.9.0"
end

0 comments on commit 94f588c

Please sign in to comment.