-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
42 #46
42 #46
Conversation
public void fetchesComments() throws Exception { | ||
final Repo repo = repo(); | ||
final Request req = request(); | ||
final GhIssue ghIssue = new GhIssue(req, repo, 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This variable name is too complex, see https://github.com/tpc2/qulice/wiki/mistakes#variable-names
@carlosmiranda looks very good, well done! I've made some comments above, please take them into account and correct your branch |
@yegor256 made changes based on your review, thanks! |
Looks perfect now, good to merge |
Hey, let me try to merge your branch |
I've merged your branch
|
Pull request for issue #42 (Created GHIssueTest.java unit test class).