Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

42 #46

Merged
5 commits merged into from
Dec 22, 2013
Merged

42 #46

5 commits merged into from
Dec 22, 2013

Conversation

carlosmiranda
Copy link
Contributor

Pull request for issue #42 (Created GHIssueTest.java unit test class).

public void fetchesComments() throws Exception {
final Repo repo = repo();
final Request req = request();
final GhIssue ghIssue = new GhIssue(req, repo, 1);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yegor256
Copy link
Member

@carlosmiranda looks very good, well done! I've made some comments above, please take them into account and correct your branch

@carlosmiranda
Copy link
Contributor Author

@yegor256 made changes based on your review, thanks!

@yegor256
Copy link
Member

Looks perfect now, good to merge

@ghost ghost self-assigned this Dec 22, 2013
@ghost
Copy link

ghost commented Dec 22, 2013

Hey, let me try to merge your branch 42 from carlosmiranda/jcabi-github into branch master of jcabi/jcabi-github. If there won't be any merge conflicts, I'll try to build it. If it builds without errors, I will merge this pull request. I will let you know in any case, in a few...

@ghost
Copy link

ghost commented Dec 22, 2013

I've merged your branch 42 into master of jcabi/jcabi-github without any merge conflicts. Then, I've built the code and found no problems. Thus, this pull request is accepted and will be merged in a few seconds.

$ Crontab `*/5 * * * *`  allowed execution
  SUCCESS 355ms
$ parallel  allowed with 1 thread(s)
  SUCCESS 3min
$ found 9 pull request(s) in Github
  SUCCESS 22.1s
$ 1 out of 9 request(s) approved
  SUCCESS 37.9s
$ merging request 46
   ?
$ notified GitHub pull request 46 that merging started
  SUCCESS 15.4s
$ EC2 `m1.small` instance `i-0034282f` created in `us-east-1a`
  SUCCESS 31.0s
$ uploaded `.ssh/config`
  SUCCESS 2min
$ uploaded `.ssh/id_rsa`
  SUCCESS 12min
$ chmod 600 ~/.ssh/id\_rsa
  SUCCESS 81ms
$ chmod 600 ~/.ssh/config
  SUCCESS 31ms
$ git clone ssh:https://[email protected]/carlosmiranda/jcabi-github.git code
  SUCCESS 6.0s
$ cd code
  SUCCESS 40ms
$ git remote add dest ssh:https://[email protected]/jcabi/jcabi-github.git
  SUCCESS 48ms
$ git remote update -p
  SUCCESS 861ms
$ git fetch
  SUCCESS 377ms
$ git checkout -b src origin/42
  SUCCESS 726ms
$ git checkout -b dest dest/master
  SUCCESS 147ms
$ git merge src
  SUCCESS 131ms
$ mvn rultor:steps clean install -B -C -Pqulice >&2 1> >(col -b | tee -a ../log.txt) 2> >(col -b | tee -a ../log.txt >&2)
  SUCCESS 4min
$ `org.apache.maven.plugins:maven-clean-plugin:clean`
  SUCCESS 501ms
$ `org.codehaus.mojo:jslint-maven-plugin:jslint`
  SUCCESS 10.7s
$ `org.codehaus.mojo:buildnumber-maven-plugin:create`
  SUCCESS 3.9s
$ `org.apache.maven.plugins:maven-resources-plugin:resources`
  SUCCESS 249ms
$ `org.apache.maven.plugins:maven-compiler-plugin:compile`
  SUCCESS 34.1s
$ `com.jcabi:jcabi-maven-plugin:ajc`
  SUCCESS 28.1s
$ `org.apache.maven.plugins:maven-resources-plugin:testResources`
  SUCCESS 368ms
$ `org.apache.maven.plugins:maven-compiler-plugin:testCompile`
  SUCCESS 6.5s
$ `com.jcabi:jcabi-maven-plugin:ajc`
  SUCCESS 7.1s
$ `org.apache.maven.plugins:maven-surefire-plugin:test`
  SUCCESS 30.4s
$ `com.jcabi:jcabi-maven-plugin:versionalize`
  SUCCESS 113ms
$ `org.apache.maven.plugins:maven-jar-plugin:jar`
  SUCCESS 3.2s
$ `org.apache.maven.plugins:maven-failsafe-plugin:integration-test`
  SUCCESS 4.8s
$ `com.qulice:qulice-maven-plugin:check`
  SUCCESS 1min
$ `org.apache.maven.plugins:maven-dependency-plugin:analyze-only`
  SUCCESS 4.5s
$ `org.apache.maven.plugins:maven-dependency-plugin:analyze-dep-mgt`
  SUCCESS 5ms
$ `org.apache.maven.plugins:maven-dependency-plugin:analyze-duplicate`
  SUCCESS 124ms
$ `com.ning.maven.plugins:maven-duplicate-finder-plugin:check`
  SUCCESS 3.7s
$ `org.codehaus.mojo:xml-maven-plugin:validate`
  SUCCESS 1.9s
$ `org.apache.maven.plugins:maven-failsafe-plugin:verify`
  SUCCESS 27ms
$ `org.apache.maven.plugins:maven-install-plugin:install`
  SUCCESS 224ms
$ EC2 instance `i-0034282f` terminated
  SUCCESS 14.3s
$ EC2 `m1.small` instance in `us-east-1a` costed $0.06
  SUCCESS 4.1s
$ com.rultor.guard.github.GhRequest#accept()
   ?

ghost pushed a commit that referenced this pull request Dec 22, 2013
@ghost ghost merged commit b7d284b into jcabi:master Dec 22, 2013
ghost pushed a commit that referenced this pull request Feb 13, 2014
merge from master to my repo
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants