add class GhMarkdownTest.java #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| /** | ||
| * Verify return string. | ||
| * @todo #32:15min add verification that render() returns correct string |
There was a problem hiding this comment.
I was wrong about the format. It should be [0-9]+(\.[0-9])?. So, in your case, it's @todo #32:0.2hr
|
@mits0908 I've made a comment about the todo tag. Should work now. |
|
@mits0908 let me know when the rest of the code is ready for review |
| import org.mockito.Mockito; | ||
|
|
||
| /** | ||
| * Created with IntelliJ IDEA. |
|
@mits0908 I've made my comments above. Let me know if you need help. |
|
BTW. class GhMarkdownTest.java is testing interface Markdown, we cannot test GhMarkdown class because it is final. |
| */ | ||
| @Test | ||
| public void returnStringWhenPassNullToRender() throws Exception { | ||
| final String notNull = "JSON can't be NULL"; |
There was a problem hiding this comment.
This test case is not testing anything. You're using Mockito in a wrong way. I'd recommend you to read about TDD, JUnit and Mockito first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.