RunMojo.java:43-45: Let's avoid code duplication between...

[dmarkov]

Puzzle 41-e81ff08d in src/main/java/com/jcabi/dynamodb/maven/plugin/RunMojo.java:43-45 has to be resolved: Let's avoid code duplication between this class and StartMojo. One idea is to create a decorator called ThreadedMojo that receives another mojo in its constructor and, when called, runs it inside a thread.... The puzzle was created by Denis N. Antonioli on 17-Dec-2015.

If you have any technical questions, don't ask me, submit new tickets instead

---

- `42-3038f9e6`/#46 (by )

[dmarkov]

@jrdalpra please proceed, it's yours

[dmarkov]

@yegor256 there is a puzzle in this code 42-3038f9e6/#46, we'll resolve it later

[jrdalpra]

@dmarkov there's no puzzle here https://github.com/jcabi/jcabi-dynamodb-maven-plugin/blob/master/src/main/java/com/jcabi/dynamodb/maven/plugin/RunMojo.java#L43

[jrdalpra]

@dmarkov I don't really think that this is a good issue. There's no code duplication here. https://github.com/jcabi/jcabi-dynamodb-maven-plugin/blob/master/src/main/java/com/jcabi/dynamodb/maven/plugin/Instances.java already encapsulates all the work.

[jrdalpra]

@pinaf @denisa can you explain this issue to me? Thanks.

[pinaf]

@jrdalpra the difference between RunMojo and StartMojo seems to be just the threading.

[denisa]

StartMojo launches dynamodb on a thread; the thread is killed once the jvm ends.
So, calling mvn dynamodb:start will launch dynamodb, then end the jvm and kill dynmodb

RunMojo launches dynamodb on the main thread.
So, calling mvn dynamodb:run will launch dynamodb and never return.

On Jan 7, 2016, at 08:55, José V. Dal Prá Junior [email protected] wrote:

@denisa https://github.com/denisa can you explain this issue to me? Thanks.

—
Reply to this email directly or view it on GitHub #42 (comment).

Two ways to build software:
(1) make it so simple that there are obviously no bugs,
(2) make it so complicated that there are no obvious bugs.
-- C.A.R. Hoare (1980 Turing Award Lecture)

[jrdalpra]

@pinaf @denisa I don't see any difference at both implementation. Both users start method at Instance class. Only differences are the name and the maven build phase. What's the point?

[jrdalpra]

@pinaf I'm not seeing this difference at souce code. Can you show me line? Thanks.

[pinaf]

@jrdalpra here's what happened: #43

[pinaf]

@yegor256 looks like this issue is invalid as @simonjenga fixed it in another PR (#43)

[jrdalpra]

@yegor256 @dmarkov @pinaf :) That's true. We are trying to solve something that's already solved. :)

[jrdalpra]

@dmarkov can you close the issue? thanks.

[dmarkov]

@yegor256 Closing, thanks all

[dmarkov]

@jrdalpra Much obliged! I have added 1 hour to your account in payment "AP-3MN93852HE477612F", 49 mins spent... m=49, that's why a bonus here for fast delivery... added +60 to your rating, now it is equal to +218

[dmarkov]

@dmarkov can you close the issue? thanks.

@jrdalpra closed

[jrdalpra]

@dmarkov thanks :)

[dmarkov]

@dmarkov thanks :)

@jrdalpra no problem :)

[dmarkov]

@yegor256 last puzzled solved 42-3038f9e6/#46

[0pdd]

@dmarkov all puzzles are solved

[0pdd]

@dmarkov all puzzles are solved