Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create-tables goal expects provisioned throughput to be a string not a number #39

Closed
keithbranton opened this issue Nov 24, 2015 · 3 comments

Comments

@keithbranton
Copy link
Contributor

Thanks for the really useful plugin. Found a minor problem...

When the aws dynamodb create-table --generate-cli-skeleton is issued these are numbers.

This difference means I can't use the same file for creating the table in my local environment using aws dynamodb create-table --cli-input-json table.json

I realize that you will want to maintain backward compatibility, but it should be easy to change your plugiun to accept either number or text values for these.

I could probably hack together a PR if it would expedite matters.

@dmarkov
Copy link

dmarkov commented Nov 30, 2015

@yegor256 please dispatch this issue

@yegor256
Copy link
Member

@keithbranton thanks for the ticket! Would be great if you can contribute with a pull request!

keithbranton pushed a commit to zanebenefits/jcabi-dynamodb-maven-plugin that referenced this issue Nov 30, 2015
keithbranton pushed a commit to zanebenefits/jcabi-dynamodb-maven-plugin that referenced this issue Nov 30, 2015
@keithbranton
Copy link
Contributor Author

This was part of the 0.7.2 release - closing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants