WarFile.java:147-148: Implement validation of JSON inside... #16 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me find a reviewer for this pull request, thanks for submitting it |
|
@krzyk please review |
| @@ -100,4 +103,32 @@ public void checkEbextensionsValidityThrowsExceptionNoConfigFiles() | |||
| ); | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * Verifies that checkEbextensionsValidity runs fine | |||
There was a problem hiding this comment.
- WarFile can use a .ebextensions with valid json
|
@nhekfqn few comments above, and you should add a test for invalid json also |
|
@krzyk please review. |
| * @return ZipFile mock. | ||
| * @throws IOException Thrown in case of error. | ||
| */ | ||
| private ZipFile zipWithEbextensionsWithText(final String text) |
There was a problem hiding this comment.
just zipWithEbextensions(final String text) is enough
|
@nhekfqn we are almost there :), see my comments above |
|
@nhekfqn You can use ExpectedException for checking message |
|
@krzyk please review. |
|
|
||
| /** | ||
| * WarFile throws exception when .ebextensions contains invalid json. | ||
| * @todo #16 enable test when WarFile.validYaml implemented |
There was a problem hiding this comment.
@todo #16:15min Enable this test when WarFile.validYaml is implemented.
|
@nhekfqn a comment about todo formatting |
|
@krzyk Please review. |
|
@rultor merge pls |
|
@rultor deploy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.