-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build failed on windows with lots of EOL violations #25
Comments
@yegor256 please dispatch this issue |
@yegor256. It is known problem, qulice fail if default system EOF not like in linux. So we need add .attributes to repository for force setting Unix-like end of line to git repository. |
@YamStranger build is passing in appveyor |
@yegor256 AppVeyor use linux like EOF for repositories by default for all git repo - it is system configuration. |
@YamStranger why can't you use the same? |
@yegor256. Because it out of scope this repo. So you need add this in instructions - and this is issue too (it can be fix). Developers create issues like below not for fun, but because of problem: @yegor256 If such issues exist at other repos - this means that this issue is valid too. Please reopen issue |
@YamStranger hm... so you're suggesting to add this |
@yegor256 Yes. |
@yegor256 Please reopen this issue and let's fix it. Build of repository should be successful when user follows all the instructions in description. Now it is impossible, and user must guess what he needs to fix (it is not obviously) and spend a lot of time just for "clone and build". |
@YamStranger should be fixed now, see 646c8cb |
@yegor256 Now issue is fixed, so I can close it. |
@YamStranger it's closed already, thanks |
@dmarkov Looks like we need to add .gitattributes to force EOL of the repo.
The text was updated successfully, but these errors were encountered: