Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failed on windows with lots of EOL violations #25

Closed
YamStranger opened this issue Jun 10, 2015 · 12 comments
Closed

Build failed on windows with lots of EOL violations #25

YamStranger opened this issue Jun 10, 2015 · 12 comments
Labels

Comments

@YamStranger
Copy link
Member

@dmarkov Looks like we need to add .gitattributes to force EOL of the repo.

@dmarkov
Copy link

dmarkov commented Jun 15, 2015

@yegor256 please dispatch this issue

yegor256 pushed a commit that referenced this issue Jun 16, 2015
@YamStranger
Copy link
Member Author

@yegor256. It is known problem, qulice fail if default system EOF not like in linux. So we need add .attributes to repository for force setting Unix-like end of line to git repository.
AppVeyor use linux like EOF.
This repository will not build successfully if you install git, install maven, clone repo and just build.
Here is some examples of same problem at different repositories:
This is issue same as here jcabi/jcabi-maven-skin#24 (build failed on Windows)
same is here yegor256/takes#148
fix mast be like here https://github.com/jcabi/jcabi-aether/pull/59/files#diff-fc723d30b02a4cca7a534518111c1a66 or like here jcabi/jcabi-dynamo#43

@yegor256
Copy link
Member

@YamStranger build is passing in appveyor

@YamStranger
Copy link
Member Author

@yegor256 AppVeyor use linux like EOF for repositories by default for all git repo - it is system configuration.

@yegor256
Copy link
Member

@YamStranger why can't you use the same?

@YamStranger
Copy link
Member Author

@yegor256. Because it out of scope this repo. So you need add this in instructions - and this is issue too (it can be fix).
Some repos already have such fixes -https://github.com/yegor256/thindeck/blob/master/.gitattributes, and some not - and it is a problem. It must be general rule, or fix for every repo or general instructions like SET JAVA_TOOL_OPTIONS=-Dfile.encoding=UTF-8.

Developers create issues like below not for fun, but because of problem:
yegor256/takes#148
jcabi/jcabi-maven-skin#24
jcabi/jcabi-dynamo#43 (it is fix with reference to my issue)
and here jcabi/jcabi-aether#57

@yegor256 If such issues exist at other repos - this means that this issue is valid too. Please reopen issue

@yegor256
Copy link
Member

@YamStranger hm... so you're suggesting to add this .gitattributes file to all repos?

@YamStranger
Copy link
Member Author

@yegor256 Yes.
Because I remember near 5 issues with same idea (I cant find first, but I will if you ask):
"mvn clean install -DskipTests -Dinvoker.skip=true -Pqulice " fails, and reason - default EOF for windows systems.

@YamStranger
Copy link
Member Author

@yegor256 Please reopen this issue and let's fix it. Build of repository should be successful when user follows all the instructions in description. Now it is impossible, and user must guess what he needs to fix (it is not obviously) and spend a lot of time just for "clone and build".

@yegor256
Copy link
Member

@YamStranger should be fixed now, see 646c8cb

@YamStranger
Copy link
Member Author

@yegor256 Now issue is fixed, so I can close it.

@yegor256
Copy link
Member

@YamStranger it's closed already, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants