Gritter Accessibility Changes

Adding in return false on the click function instead of the javascript void in the link href.
jboesch · Jul 15, 2013 · fc199cc · fc199cc
1 parent 25bdf6f
commit fc199cc
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/js/jquery.gritter.js b/js/jquery.gritter.js
@@ -78,7 +78,7 @@
  _custom_timer: 0,
  _item_count: 0,
  _is_setup: 0,
- _tpl_close: '<a class="gritter-close" href="javascript:void(0);" tabindex="1">Close Notification</a>',
+ _tpl_close: '<a class="gritter-close" href="#" tabindex="1">Close Notification</a>',
  _tpl_title: '<span class="gritter-title">[[title]]</span>',
  _tpl_item: '<div id="gritter-item-[[number]]" class="gritter-item-wrapper [[item_class]]" style="display:none" role="alert"><div class="gritter-top"></div><div class="gritter-item">[[close]][[image]]<div class="[[class_name]]">[[title]]<p>[[text]]</p></div><div style="clear:both"></div></div><div class="gritter-bottom"></div></div>',
  _tpl_wrap: '<div id="gritter-notice-wrapper"></div>',
@@ -182,6 +182,7 @@
  // Clicking (X) makes the perdy thing close
  $(item).find('.gritter-close').click(function(){
  Gritter.removeSpecific(number, {}, null, true);
+ return false;
  });
 
  return number;

diff --git a/js/jquery.gritter.min.js b/js/jquery.gritter.min.js