Fixes #100 - Add support for tinkerpop gremlin server 3.3 (GraphSONMessageSerializerV3d0) #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctdio
changed the title
|
@jbmusso could I get some feedback on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support usage with Tinkerpop Gremlin Server 3.3 (which uses GraphSONMessageSerializerV3d0).
A lot of the changes come from
prettierdoing it's formatting. The main change is inexecuteHandler.jsandGremlinClient.js, which in both cases simply tries to use thedataobject's@valueproperty if it exists and will fallback to usingdata. The rest of the changes were done to allow tests to be run with both 3.2 and 3.3.I was originally going to normalize the incoming data into a nicer format (the new format is a pain to parse), but it is probably best to offload that work to consumers of this library.