Skip to content

Commit

Permalink
fixed todo related to properly halting the stream (#98)
Browse files Browse the repository at this point in the history
  • Loading branch information
JacobWeyer authored and jbmusso committed Dec 18, 2017
1 parent 3b62272 commit 8675c99
Showing 1 changed file with 4 additions and 23 deletions.
27 changes: 4 additions & 23 deletions gremlin-client/src/executeHandler.js
Original file line number Diff line number Diff line change
@@ -1,29 +1,10 @@
import highland from 'highland';
import _ from 'lodash';

function defaultExecuteHandler(messageStream, callback) {
let errored = false;
let objectMode = false;

const defaultExecuteHandler = (messageStream, callback) =>
highland(messageStream)
.stopOnError(err => {
// TODO: this does not seem to halt the stream properly, and make
// the callback being fired twice. We need to get rid of the ugly
// errored variable check.
errored = true;
callback(err);
})
.map(({ result: { data } }) => {
objectMode = !_.isArray(data);

return data;
})
.map(({ result: { data } }) => data)
.sequence()
.toArray(results => {
if (!errored) {
callback(null, objectMode ? results[0] : results);
}
});
}
.collect()
.toCallback(callback);

export default defaultExecuteHandler;

0 comments on commit 8675c99

Please sign in to comment.