Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixing canrager SAEs in SAEs table docs #304

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

chanind
Copy link
Collaborator

@chanind chanind commented Sep 25, 2024

Description

This PR fixes docs/generate_sae_table.py to support canrager SAEs, which is breaking when building docs. Currently, the code to load the config file for building the SAEs table re-implements the converter loading code, I think because the converters also download the full SAEs which is not necessary for building the table.

This PR also removes docs/sae_table.md from git and adds it to .gitignore since this is auto-generated by CI anyway and the file in the repo is ignored.

Longer-term, we should refactor the converters to allow loading only the config and not the full SAE so we don't have to remember to implement new converters in 2 places.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have not rewritten tests relating to key interfaces which would affect backward compatibility

You have tested formatting, typing and unit tests (acceptance tests not currently in use)

  • I have run make check-ci to check format and linting. (you can run make format to format code if needed.)

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.36%. Comparing base (cdc64c1) to head (16ba8e1).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #304   +/-   ##
=======================================
  Coverage   62.36%   62.36%           
=======================================
  Files          25       25           
  Lines        3135     3135           
  Branches      546      546           
=======================================
  Hits         1955     1955           
  Misses       1077     1077           
  Partials      103      103           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbloomAus
Copy link
Owner

thanks for the fix!

@jbloomAus jbloomAus merged commit 54cfc67 into main Sep 26, 2024
7 checks passed
zhenningdavidliu pushed a commit to decandido/SAELens that referenced this pull request Oct 4, 2024
tom-pollak pushed a commit to tom-pollak/SAELens that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants