fix: fixing canrager SAEs in SAEs table docs #304
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes
docs/generate_sae_table.py
to support canrager SAEs, which is breaking when building docs. Currently, the code to load the config file for building the SAEs table re-implements the converter loading code, I think because the converters also download the full SAEs which is not necessary for building the table.This PR also removes
docs/sae_table.md
from git and adds it to.gitignore
since this is auto-generated by CI anyway and the file in the repo is ignored.Longer-term, we should refactor the converters to allow loading only the config and not the full SAE so we don't have to remember to implement new converters in 2 places.
Type of change
Please delete options that are not relevant.
Checklist:
You have tested formatting, typing and unit tests (acceptance tests not currently in use)
make check-ci
to check format and linting. (you can runmake format
to format code if needed.)