Quality of Life Refactor of SAE Lens adding SAE Analysis with HookedSAETransformer and some other breaking changes. #162
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, we support HookedSAETransformer (coming over from TransformerLens) and refactor a bunch of stuff internally. I'm sorry this PR is so large and for the number of breaking changes. I'm hoping that the future need for refactors is much smaller. We expect the changes to be fairly superficial / easy to adapt to except for those working on forks. Feel free to reach out for assistance / clarification if you are trying to update a fork. Finally, we think it's likely there are no major regressions or introduced bugs, but the test coverage now looks lower as we're showing over the entire repo and not just the training subpackage.
New Features:
SAE
notSAEConfig
.Breaking changes:
Features we removed:
Renaming:
Notes:
Type of change
Please delete options that are not relevant.
Checklist:
You have tested formatting, typing and unit tests (acceptance tests not currently in use)
make check-ci
to check format and linting. (you can runmake format
to format code if needed.)Performance Check.
If you have implemented a training change, please indicate precisely how performance changes with respect to the following metrics:
Please links to wandb dashboards with a control and test group.