-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit-test/Travis CI: Cleaner Log, Features; Closes #137 #160
Conversation
from #137 :
We solved this by loading the spacy en_core_web_sm model in a different way. The log looks much nicer now, no more IOErrors etc. 🪂 |
The only things that are still annoying in the log are both warnings when testing (we were able to fix all other warnings etc.)
|
Changes in |
Yes I think so. Will test some more stuff and incorporate the changes from above soon. |
Now ready to merge from my side 🥈 |
Amazing, it looks much more beautiful yet! There is still a warning:
Do you know where it came from? Can we remove it? Also, I noticed how we don't have a clear position regarding the CR/CRLF issue (you changed the kind of ending newline in the first two files). I will take care of this by bulk-formating all files and will update the CONTRIBUTION.md accordingly. |
Aaaah, now it all makes sense: that's why we were skipping the doctest in
Yes, makes sense 🙆♂️ |
Thanks, merged! 🎉 (had to fix some conflicts, but should be good!) |
No description provided.