Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit-test/Travis CI: Cleaner Log, Features; Closes #137 #160

Merged
merged 11 commits into from
Sep 14, 2020

Conversation

henrifroese
Copy link
Collaborator

No description provided.

@henrifroese henrifroese changed the title Unit-test/Travis CI: Cleaner Log, Features; closes #137 Unit-test/Travis CI: Cleaner Log, Features; Closes #137 Aug 22, 2020
@henrifroese
Copy link
Collaborator Author

henrifroese commented Aug 22, 2020

from #137 :

Also, sometimes the Travis CI does not fail even if some errors are raised, see example below at line 576 for instance (`raise IOError(Errors.E050.format(name=name))). This should also investigate further. In this case, we may want the job to fail rather than pass?

We solved this by loading the spacy en_core_web_sm model in a different way. The log looks much nicer now, no more IOErrors etc. 🪂

@henrifroese
Copy link
Collaborator Author

henrifroese commented Aug 22, 2020

The only things that are still annoying in the log are both warnings when testing (we were able to fix all other warnings etc.)

  1. warning when importing plotly.express in visualization; we could filter this with with warnings.filter.... but that's not really nice when importing - might make sense though
  2. Warnings from Gtk.Widget...; probably somewhere from visualization.py, but we were not able to find these 😠 😡 👿 :rage4:

texthero/nlp.py Outdated Show resolved Hide resolved
texthero/_helper.py Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
@jbesomi
Copy link
Owner

jbesomi commented Sep 8, 2020

Changes in .travis.yml are due to a previous PR?

@henrifroese
Copy link
Collaborator Author

Changes in .travis.yml are due to a previous PR?

Yes I think so. Will test some more stuff and incorporate the changes from above soon.

@henrifroese
Copy link
Collaborator Author

Now ready to merge from my side 🥈

@jbesomi
Copy link
Owner

jbesomi commented Sep 12, 2020

Amazing, it looks much more beautiful yet!

There is still a warning:

There are NaNs (missing values) in the given input series. They were replaced with appropriate values before the function was applied. Consider using hero.fillna to replace those NaNs yourself or hero.drop_no_content to remove them.

Do you know where it came from? Can we remove it?

Also, I noticed how we don't have a clear position regarding the CR/CRLF issue (you changed the kind of ending newline in the first two files). I will take care of this by bulk-formating all files and will update the CONTRIBUTION.md accordingly.

@henrifroese
Copy link
Collaborator Author

There is still a warning:

Aaaah, now it all makes sense: that's why we were skipping the doctest in _helper.py with the replace_b_with_c. That makes sense as a doctest with warnings.filterwarnings is really ugly 🤢 and we're testing the function in test_helpers.py anyways. So I'll skip this doctest again and we're good 🌛

Also, I noticed how we don't have a clear position regarding the CR/CRLF issue (you changed the kind of ending newline in the first two files). I will take care of this by bulk-formating all files and will update the CONTRIBUTION.md accordingly.

Yes, makes sense 🙆‍♂️

@jbesomi jbesomi merged commit b880515 into jbesomi:master Sep 14, 2020
@jbesomi
Copy link
Owner

jbesomi commented Sep 14, 2020

Thanks, merged! 🎉 (had to fix some conflicts, but should be good!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants