Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#444 leeway implementation #445

Merged
merged 2 commits into from
Aug 19, 2021
Merged

#444 leeway implementation #445

merged 2 commits into from
Aug 19, 2021

Conversation

domdinicola
Copy link
Contributor

No description provided.

Andrew-Chen-Wang
Andrew-Chen-Wang requested changes Aug 18, 2021
View reviewed changes
Copy link
Member

@Andrew-Chen-Wang Andrew-Chen-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a simple test for this new setting. Thank you!

docs/settings.rst Outdated Show resolved Hide resolved
@Andrew-Chen-Wang Andrew-Chen-Wang linked an issue Aug 18, 2021 that may be closed by this pull request
JWT Leeway #444
Closed
@domdinicola
Copy link
Contributor Author

@Andrew-Chen-Wang thanks for the suggestion

@domdinicola domdinicola force-pushed the implement-leeway branch 2 times, most recently from c9e1e72 to c3a7438 Compare August 18, 2021 21:19
@Andrew-Chen-Wang
Copy link
Member

Andrew-Chen-Wang commented Aug 19, 2021 •
edited
Loading

Thanks for implementing the tests and the PR!

@Andrew-Chen-Wang Andrew-Chen-Wang merged commit 4d7c764 into jazzband:master Aug 19, 2021
@domdinicola domdinicola deleted the implement-leeway branch August 19, 2021 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andrew-Chen-Wang Andrew-Chen-Wang Andrew-Chen-Wang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JWT Leeway
2 participants
@domdinicola @Andrew-Chen-Wang