Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added django 4 to CI #580

Merged
merged 6 commits into from
Dec 21, 2021
Merged

Added django 4 to CI #580

merged 6 commits into from
Dec 21, 2021

Conversation

WisdomPill
Copy link
Member

@WisdomPill WisdomPill commented Dec 17, 2021

Fixes #579

Added support for django 4.0

@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #580 (cb26c50) into master (218e47c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #580   +/-   ##
======================================
  Coverage    57.8%   57.8%           
======================================
  Files          39      39           
  Lines        2497    2497           
  Branches       73      73           
======================================
  Hits         1441    1441           
  Misses       1041    1041           
  Partials       15      15           
Flag Coverage Δ
mypy 33.9% <ø> (ø)
tests 83.3% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 218e47c...cb26c50. Read the comment docs.

@WisdomPill WisdomPill mentioned this pull request Dec 17, 2021
Copy link
Contributor

@hartwork hartwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @WisdomPill , four things I noticed:

  • Adding support for Django 4 seems uncontroversial, dropping 2.2 prior to EOL could be considered controversial by some; I'd split those in two pull requests personally
  • The current title of the pull request does not mention dropping Django 2.2; my vote for adding that
  • Django 3.1 is EOL even before Django 2.2 (see image below) but it is not being dropped; why not?
  • Dropping of Django 2.2 seems to be incomplete, e.g. I still see a line 2.2: dj22 in setup.cfg, maybe more.

Just my 2 cents.

Django releases

@hartwork
Copy link
Contributor

hartwork commented Dec 21, 2021

  • Dropping of Django 2.2 seems to be incomplete, e.g. I still see a line 2.2: dj22 in setup.cfg, maybe more.

PS: @WisdomPill there is indeed one more: README.rst still says Django 2.2+ after this PR in status quo.

@WisdomPill
Copy link
Member Author

my mistake, dropping 2.2 is a mistake the docs were saying that support for django 1.11 has dropped in april 2020

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@WisdomPill
Copy link
Member Author

thanks @hartwork !

@WisdomPill WisdomPill merged commit 06d7553 into jazzband:master Dec 21, 2021
@WisdomPill WisdomPill deleted the 579/feature branch December 21, 2021 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add django 4 to CI
2 participants