Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handled onActivityResult exceptions #199

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Conversation

anirudhsharma392
Copy link

This PR resolves the issue.
Handled the app crash inside OnActivityResult.

@AnirudhLoya
Copy link

By when this PR be merged to production & new update be released for #33 crash issue?

@danishkhawaja98
Copy link

@jaumard
Please merge this PR.

@danishkhawaja98
Copy link

Hi @jaumard

Just like what you have done on Line # 17 to Line # 25 on dart code and Line # 85 to Line # 87 on android code, we also need to implement the same method on Line # 30 on dart code and Line # 99 on android code to resolve this crash issue.

Reference attachment

@AnirudhLoya
Copy link

AnirudhLoya commented Jul 31, 2023 via email

@danishkhawaja98
Copy link

Pls merge if crash issue is resolved.

On Mon, Jul 31, 2023 at 7:02 PM Danish Khawaja @.> wrote: Hi @jaumard https://github.com/jaumard Just like what you have done on Line # 17 https://github.com/jaumard/sms_autofill/blob/7b5234c007267bee0e565a1fd50ec0b4a6d97063/lib/sms_autofill.dart#L17C5-L17C5 to Line # 25

on dart code and Line # 85 to Line # 87 on android code, we also need to implement the same method on Line # 30
final String? hint = await _channel.invokeMethod('requestPhoneHint');
on dart code and Line # 99 on android code to resolve this crash issue. Reference attachment - https://stackoverflow.com/questions/65666404/java-lang-illegalstateexception-reply-already-submitted-when-trying-to-call — Reply to this email directly, view it on GitHub <#199 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABK52ZRVBEXA3VTXDJQZ3BDXS6XWRANCNFSM6AAAAAAYWUU3RQ . You are receiving this because you commented.Message ID: @.
>
-- Thank you Aniruddh Loya

I don't have the write access, @jaumard has.
The crash issue is resolved, but the phone number is displayed on the field when we click two times on the phone number from the dialog that appears.

@jaumard
Copy link
Owner

jaumard commented Nov 20, 2023

Thanks for this, sorry for the delay

@jaumard jaumard merged commit ca62e48 into jaumard:master Nov 20, 2023
@debojyoti452
Copy link

@jaumard The last release was nine months ago. When can we expect this fix to be published?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants