Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spurious underscores in Makefile syntax highlighting #1032

Closed
jstolarek opened this issue May 21, 2024 · 1 comment
Closed

Spurious underscores in Makefile syntax highlighting #1032

jstolarek opened this issue May 21, 2024 · 1 comment

Comments

@jstolarek
Copy link

I updated Hakyll to version 4.16.2.0 and noticed a questionable change in syntax highlighting. Consider this snippet of a Makefile:

```Makefile
all:
       git add .
       git commit -m "Local changes (via Makefile)" || exit 0

.PHONY: all
\```

This is how it used to render:

before

vs how it renders now:

after

Note the extra leading underscores. Generated HTML before:

<span id="cb1-2"><a href="#cb1-2" aria-hidden="true" tabindex="-1"></a>       git add .</span>

and after:

<span id="cb1-2"><a href="#cb1-2" aria-hidden="true" tabindex="-1"></a><span class="er">       </span>git add .</span>
jstolarek added a commit to jstolarek/jstolarek.github.io that referenced this issue May 21, 2024
@Minoru
Copy link
Collaborator

Minoru commented May 21, 2024

Hakyll relies on Pandoc for syntax highlighting, which in turn relies on https://hackage.haskell.org/package/skylighting. Most likely skylighting and/or pandoc got updated when updating Hakyll, breaking the resulting HTML. Please report the problem to one of those projects instead.

@Minoru Minoru closed this as completed May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants